From 3f606177e3f65e723912fc84469d84e5e08c2ee1 Mon Sep 17 00:00:00 2001 From: Furgo <148809153+furgo16@users.noreply.github.com> Date: Wed, 18 Jun 2025 09:54:59 +0200 Subject: [PATCH] Import: DXF parser, remove original unsupported features count and warning --- src/Mod/Import/App/dxf/dxf.cpp | 17 ----------------- src/Mod/Import/App/dxf/dxf.h | 1 - 2 files changed, 18 deletions(-) diff --git a/src/Mod/Import/App/dxf/dxf.cpp b/src/Mod/Import/App/dxf/dxf.cpp index 01d59a04d0..7afbb3c887 100644 --- a/src/Mod/Import/App/dxf/dxf.cpp +++ b/src/Mod/Import/App/dxf/dxf.cpp @@ -2404,12 +2404,6 @@ void CDxfRead::UnsupportedFeature(const char* format, args&&... argValuess) // NOLINTNEXTLINE(runtime/printf) std::string formattedMessage = fmt::sprintf(format, std::forward(argValuess)...); m_stats.unsupportedFeatures[formattedMessage]++; - // *** This message is now disabled here because we use the stats reporter instead *** - // We place these formatted messages in a map, count their occurrences and not their first - // occurrence. - // if (m_unsupportedFeaturesNoted[formattedMessage].first++ == 0) { - // m_unsupportedFeaturesNoted[formattedMessage].second = m_line; - // } } bool CDxfRead::get_next_record() @@ -2730,17 +2724,6 @@ void CDxfRead::DoRead(const bool ignore_errors /* = false */) } } FinishImport(); - - // Flush out any unsupported features messages - if (!m_unsupportedFeaturesNoted.empty()) { - ImportError("Unsupported DXF features:\n"); - for (auto& featureInfo : m_unsupportedFeaturesNoted) { - ImportError("%s: %d time(s) first at line %d\n", - featureInfo.first, - featureInfo.second.first, - featureInfo.second.second); - } - } } catch (const Base::Exception& e) { // This catches specific FreeCAD exceptions and re-throws them. diff --git a/src/Mod/Import/App/dxf/dxf.h b/src/Mod/Import/App/dxf/dxf.h index 8bd97937d4..caafca4989 100644 --- a/src/Mod/Import/App/dxf/dxf.h +++ b/src/Mod/Import/App/dxf/dxf.h @@ -716,7 +716,6 @@ protected: void UnsupportedFeature(const char* format, args&&... argValues); private: - std::map> m_unsupportedFeaturesNoted; std::string m_CodePage; // Code Page name from $DWGCODEPAGE or null if none/not read yet // The following was going to be python's canonical name for the encoding, but this is (a) not // easily found and (b) does not speed up finding the encoding object.