From 41ca54de7006b4620f7c553e0c2265fc79d3d78d Mon Sep 17 00:00:00 2001 From: wmayer Date: Tue, 28 Jul 2020 09:49:20 +0200 Subject: [PATCH] LGTM: [skip ci] remove some obsolete FIXME comments from source code --- src/Base/Reader.cpp | 1 - src/Base/Writer.cpp | 2 -- src/Gui/Application.cpp | 7 +------ 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/src/Base/Reader.cpp b/src/Base/Reader.cpp index dd7ad2d7f6..6fa9e3733e 100644 --- a/src/Base/Reader.cpp +++ b/src/Base/Reader.cpp @@ -69,7 +69,6 @@ Base::XMLReader::XMLReader(const char* FileName, std::istream& str) #ifdef _MSC_VER str.imbue(std::locale::empty()); #else - //FIXME: Check whether this is correct str.imbue(std::locale::classic()); #endif diff --git a/src/Base/Writer.cpp b/src/Base/Writer.cpp index 8741e79368..4a0508fcbe 100644 --- a/src/Base/Writer.cpp +++ b/src/Base/Writer.cpp @@ -246,7 +246,6 @@ ZipWriter::ZipWriter(const char* FileName) #ifdef _MSC_VER ZipStream.imbue(std::locale::empty()); #else - //FIXME: Check whether this is correct ZipStream.imbue(std::locale::classic()); #endif ZipStream.precision(std::numeric_limits::digits10 + 1); @@ -259,7 +258,6 @@ ZipWriter::ZipWriter(std::ostream& os) #ifdef _MSC_VER ZipStream.imbue(std::locale::empty()); #else - //FIXME: Check whether this is correct ZipStream.imbue(std::locale::classic()); #endif ZipStream.precision(std::numeric_limits::digits10 + 1); diff --git a/src/Gui/Application.cpp b/src/Gui/Application.cpp index a59f668f3d..a68a75b82b 100644 --- a/src/Gui/Application.cpp +++ b/src/Gui/Application.cpp @@ -784,13 +784,8 @@ void Application::slotNewDocument(const App::Document& Doc, bool isMainDoc) pDoc->signalResetEdit.connect(boost::bind(&Gui::Application::slotResetEdit, this, bp::_1)); signalNewDocument(*pDoc, isMainDoc); - if(isMainDoc) + if (isMainDoc) pDoc->createView(View3DInventor::getClassTypeId()); - // FIXME: Do we really need this further? Calling processEvents() mixes up order of execution in an - // unpredictable way. At least it seems that with Qt5 we don't need this any more. -#if QT_VERSION < 0x050000 - // qApp->processEvents(); // make sure to show the window stuff on the right place -#endif } void Application::slotDeleteDocument(const App::Document& Doc)