kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Coverity: Dereference after null check

Browse Source
This commit is contained in:
wmayer
2020-07-19 15:44:52 +02:00
parent 433ec2d6e4
commit 421f6c52cb
11 changed files with 59 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/Mod/Part/Gui/ViewProviderExt.cpp
View File

@@ -929,11 +929,10 @@ void ViewProviderPartExt::reload()
void ViewProviderPartExt::updateData(const App::Property* prop)
{
const char *propName = prop?prop->getName():"";
if(propName && (strcmp(propName,"Shape")==0 || strstr(propName,"Touched")!=0))
{
const char *propName = prop->getName();
if (propName && (strcmp(propName, "Shape") == 0 || strstr(propName, "Touched") != nullptr)) {
// calculate the visual only if visible
if (isUpdateForced()||Visibility.getValue())
if (isUpdateForced() || Visibility.getValue())
updateVisual();
else
VisualTouched = true;