Draft: fix setting of self.Type

Fixes #17750.

`self.Type` should be set in `__init__` and `loads`, and not in `onDocumentRestored`.
This commit is contained in:
Roy-043
2025-06-26 12:01:08 +02:00
committed by Chris Hennes
parent aa9c16f8c9
commit 425ea761ff
4 changed files with 22 additions and 20 deletions

View File

@@ -45,8 +45,8 @@ class Label(DraftAnnotation):
def __init__(self, obj):
obj.Proxy = self
self.set_properties(obj)
self.Type = "Label"
self.set_properties(obj)
def set_properties(self, obj):
"""Set properties only if they don't exist."""
@@ -234,7 +234,6 @@ class Label(DraftAnnotation):
"""Execute code when the document is restored."""
super().onDocumentRestored(obj)
gui_utils.restore_view_object(obj, vp_module="view_label", vp_class="ViewProviderLabel")
self.Type = "Label"
if not getattr(obj, "ViewObject", None):
return
@@ -243,6 +242,9 @@ class Label(DraftAnnotation):
return
self.update_properties_0v21(obj, vobj)
def loads(self, state):
self.Type = "Label"
def update_properties_0v21(self, obj, vobj):
"""Update view properties."""
old_fontname = vobj.TextFont