Guard all uses of basic_random_generator for thread safety

src/Mod/TechDraw/App/CosmeticVertex.cpp

@@ -32,6 +32,8 @@
 #include <App/Application.h>
 #include <Base/Persistence.h>
 #include <Base/Vector3D.h>
+#include <boost/thread/mutex.hpp>
+#include <boost/thread/thread.hpp>
 
 #include "CosmeticVertex.h"
 #include "CosmeticVertexPy.h"
@@ -235,8 +237,13 @@ std::string CosmeticVertex::getTagAsString() const
 void CosmeticVertex::createNewTag()
 {
     // Initialize a random number generator, to avoid Valgrind false positives.
+    // The random number generator is not threadsafe so we guard it.  See
+    // https://www.boost.org/doc/libs/1_62_0/libs/uuid/uuid.html#Design%20notes
     static boost::mt19937 ran;
     static bool seeded = false;
+    static boost::mutex random_number_mutex;
+
+    boost::lock_guard<boost::mutex> guard(random_number_mutex);
 
     if (!seeded) {
         ran.seed(static_cast<unsigned int>(std::time(nullptr)));