Clean up clang inconsistent override warnings.

This commit is contained in:
Ian Rees
2017-03-01 18:00:30 +13:00
committed by wmayer
parent 3d6fc352c5
commit 4303384667
21 changed files with 107 additions and 68 deletions

View File

@@ -47,7 +47,7 @@ class Cube;
*/
class TechDrawExport DrawProjGroup : public TechDraw::DrawViewCollection
{
PROPERTY_HEADER(TechDraw::DrawProjGroup);
PROPERTY_HEADER_WITH_OVERRIDE(TechDraw::DrawProjGroup);
public:
/// Constructor
@@ -66,7 +66,7 @@ public:
Base::BoundBox3d getBoundingBox() const;
double calculateAutomaticScale() const;
virtual QRectF getRect(void) const;
virtual QRectF getRect(void) const override;
virtual bool checkFit(TechDraw::DrawPage* p) const override;
/// Check if container has a view of a specific type
bool hasProjection(const char *viewProjType) const;
@@ -91,20 +91,20 @@ public:
bool distributeProjections(void);
void resetPositions(void);
short mustExecute() const;
short mustExecute() const override;
/** @name methods overide Feature */
//@{
/// recalculate the Feature
virtual void onDocumentRestored();
virtual App::DocumentObjectExecReturn *execute(void);
virtual void onDocumentRestored() override;
virtual App::DocumentObjectExecReturn *execute(void) override;
//@}
/// returns the type name of the ViewProvider
virtual const char* getViewProviderName(void) const {
virtual const char* getViewProviderName(void) const override {
return "TechDrawGui::ViewProviderProjGroup";
}
//return PyObject as DrawProjGroupPy
virtual PyObject *getPyObject(void);
virtual PyObject *getPyObject(void) override;
/// Determines either "First Angle" or "Third Angle".
App::Enumeration usedProjectionType(void);
@@ -132,7 +132,7 @@ public:
void dumpISO(char * title);
protected:
void onChanged(const App::Property* prop);
void onChanged(const App::Property* prop) override;
//! Moves anchor view to keep our bounding box centre on the origin
void moveToCentre();

View File

@@ -48,7 +48,7 @@ class DrawProjGroup;
class TechDrawExport DrawProjGroupItem : public TechDraw::DrawViewPart
{
PROPERTY_HEADER(TechDraw::DrawProjGroupItem);
PROPERTY_HEADER_WITH_OVERRIDE(TechDraw::DrawProjGroupItem);
public:
/// Constructor
@@ -58,26 +58,26 @@ public:
App::PropertyEnumeration Type;
App::PropertyVector RotationVector;
short mustExecute() const;
virtual void onDocumentRestored();
virtual void unsetupObject();
short mustExecute() const override;
virtual void onDocumentRestored() override;
virtual void unsetupObject() override;
DrawProjGroup* getGroup(void) const;
double getRotateAngle();
/// returns the type name of the ViewProvider
virtual const char* getViewProviderName(void) const {
virtual const char* getViewProviderName(void) const override {
return "TechDrawGui::ViewProviderProjGroupItem";
}
//return PyObject as DrawProjGroupItemPy
virtual PyObject *getPyObject(void);
virtual PyObject *getPyObject(void) override;
virtual gp_Ax2 getViewAxis(const Base::Vector3d& pt,
const Base::Vector3d& direction,
const bool flip=true) const override;
protected:
void onChanged(const App::Property* prop);
void onChanged(const App::Property* prop) override;
private:
static const char* TypeEnums[];

View File

@@ -37,7 +37,7 @@ class DrawPage;
class TechDrawExport DrawViewSymbol : public TechDraw::DrawView
{
PROPERTY_HEADER(TechDraw::DrawViewSymbol);
PROPERTY_HEADER_WITH_OVERRIDE(TechDraw::DrawViewSymbol);
public:
/// Constructor
@@ -50,19 +50,19 @@ public:
/** @name methods overide Feature */
//@{
/// recalculate the Feature
virtual App::DocumentObjectExecReturn *execute(void);
virtual App::DocumentObjectExecReturn *execute(void) override;
//@}
/// returns the type name of the ViewProvider
virtual const char* getViewProviderName(void) const {
virtual const char* getViewProviderName(void) const override {
return "TechDrawGui::ViewProviderSymbol";
}
virtual QRectF getRect() const;
virtual QRectF getRect() const override;
virtual bool checkFit(TechDraw::DrawPage* p) const override;
protected:
virtual void onChanged(const App::Property* prop);
virtual void onChanged(const App::Property* prop) override;
Base::BoundBox3d bbox;
};

View File

@@ -94,12 +94,14 @@ public:
~QGIViewDimension() = default;
void setViewPartFeature(TechDraw::DrawViewDimension *obj);
int type() const { return Type;}
int type() const override { return Type;}
virtual void drawBorder();
virtual void drawBorder() override;
virtual void updateView(bool update = false) override;
virtual void paint(QPainter * painter, const QStyleOptionGraphicsItem * option, QWidget * widget = 0 );
virtual QColor getNormalColor(void);
virtual void paint( QPainter * painter,
const QStyleOptionGraphicsItem * option,
QWidget * widget = 0 ) override;
virtual QColor getNormalColor(void) override;
public Q_SLOTS:
void datumLabelDragged(void);
@@ -109,8 +111,9 @@ public Q_SLOTS:
void updateDim(void);
protected:
void draw();
virtual QVariant itemChange(GraphicsItemChange change, const QVariant &value);
void draw() override;
virtual QVariant itemChange( GraphicsItemChange change,
const QVariant &value ) override;
virtual void setSvgPens(void);
virtual void setPens(void);