diff --git a/src/Base/UnitsApiPy.cpp b/src/Base/UnitsApiPy.cpp index 7efd122c2d..799ca43ad4 100644 --- a/src/Base/UnitsApiPy.cpp +++ b/src/Base/UnitsApiPy.cpp @@ -89,9 +89,7 @@ PyObject* UnitsApi::sParseQuantity(PyObject* /*self*/, PyObject* args) return new QuantityPy(new Quantity(Quantity::parse(str))); } catch (const ParserError&) { - PyErr_Format(PyExc_ValueError, - "invalid unit expression: '%s'\n", - std::string {pstr}.c_str()); + PyErr_Format(PyExc_ValueError, "invalid unit expression: '%s'\n", str.c_str()); return nullptr; } } diff --git a/tests/src/Base/SchemaTests.cpp b/tests/src/Base/SchemaTests.cpp index e6ca6f5fca..412bc8ac81 100644 --- a/tests/src/Base/SchemaTests.cpp +++ b/tests/src/Base/SchemaTests.cpp @@ -315,18 +315,51 @@ TEST_F(SchemaTest, imperial_building_special_function_length_foot) EXPECT_EQ(result, expect); } -/* - * QuantityParser::yyparse() is crashing on the >>1' 2" + 1/4"<< input, - * so disable this test +TEST_F(SchemaTest, imperial_building_special_function_zero_length) +{ + const auto result = set("ImperialBuilding", Unit::Length, 0.0); + const auto expect = Tools::escapeQuotesFromString("0"); + + EXPECT_EQ(result, expect); +} + +TEST_F(SchemaTest, imperial_building_special_function_length_negative_fraction_only) +{ + constexpr auto val {(-1.0 / 8.0) * 25.4}; // -1/8 inch in mm + const auto result = set("ImperialBuilding", Unit::Length, val); + const auto expect = Tools::escapeQuotesFromString("-1/8\""); + + EXPECT_EQ(result, expect); +} + +TEST_F(SchemaTest, imperial_building_special_function_negative_inches_and_fraction) +{ + constexpr auto val {-2.5 * 25.4}; // -2.5 inches in mm + const auto result = set("ImperialBuilding", Unit::Length, val); + const auto expect = Tools::escapeQuotesFromString("-2\" - 1/2\""); + + EXPECT_EQ(result, expect); +} + +TEST_F(SchemaTest, imperial_building_special_function_high_precision_rounding) +{ + constexpr auto val {25.396}; // Very close to exactly 1 inch + const auto result = set("ImperialBuilding", Unit::Length, val); + const auto expect = Tools::escapeQuotesFromString("1\""); + + EXPECT_EQ(result, expect); +} + TEST_F(SchemaTest, imperial_building_special_function_length) { + GTEST_SKIP() << "QuantityParser::yyparse() is crashing on the >>1' 2\" + 1/4\"<< input, " + "so disable this test"; constexpr auto val {360.6}; const auto result = set("ImperialBuilding", Unit::Length, val); const auto expect = Tools::escapeQuotesFromString("1' 2\" + 1/4\""); EXPECT_EQ(result, expect); } -*/ TEST_F(SchemaTest, imperial_building_special_function_length_neg) {