kindred/create
1
1
Fork 0
Code Issues 43 Pull Requests Actions 1 Packages Projects 9 Releases 2 Wiki Activity

Coverity: Unchecked dynamic_cast

Browse Source
This commit is contained in:
wmayer
2020-07-20 12:37:08 +02:00
parent 1a16cde1f5
commit 45b755a596
6 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Mod/TechDraw/App/DrawView.cpp
View File

@@ -235,11 +235,11 @@ DrawPage* DrawView::findParentPage() const
std::vector<App::DocumentObject*> parent = getInList();
for (std::vector<App::DocumentObject*>::iterator it = parent.begin(); it != parent.end(); ++it) {
if ((*it)->getTypeId().isDerivedFrom(DrawPage::getClassTypeId())) {
page = dynamic_cast<TechDraw::DrawPage *>(*it);
page = static_cast<TechDraw::DrawPage *>(*it);
}
if ((*it)->getTypeId().isDerivedFrom(DrawViewCollection::getClassTypeId())) {
collection = dynamic_cast<TechDraw::DrawViewCollection *>(*it);
collection = static_cast<TechDraw::DrawViewCollection *>(*it);
page = collection->findParentPage();
}