From 45be617bf331091e220802a00b3a72ed96f522eb Mon Sep 17 00:00:00 2001
From: FEA-eng <59876896+FEA-eng@users.noreply.github.com>
Date: Mon, 7 Jul 2025 17:46:19 +0200
Subject: [PATCH] Part: Enable solid creation by default for Loft and Sweep
(#22098)
* Part: Update PartFeatures.cpp
* Part: Update DlgRevolution.ui
* Part: Update TaskLoft.ui
* Part: Update TaskSweep.ui
* Part: Update PartFeatures.cpp
* Update src/Mod/Part/Gui/DlgRevolution.ui
---------
Co-authored-by: Max Wilfinger <6246609+maxwxyz@users.noreply.github.com>
---
src/Mod/Part/App/PartFeatures.cpp | 4 ++--
src/Mod/Part/Gui/TaskLoft.ui | 3 +++
src/Mod/Part/Gui/TaskSweep.ui | 3 +++
tests/src/Mod/Part/App/PartFeatures.cpp | 1 +
4 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/Mod/Part/App/PartFeatures.cpp b/src/Mod/Part/App/PartFeatures.cpp
index dab9d9219d..be5de959f7 100644
--- a/src/Mod/Part/App/PartFeatures.cpp
+++ b/src/Mod/Part/App/PartFeatures.cpp
@@ -177,7 +177,7 @@ Loft::Loft()
{
ADD_PROPERTY_TYPE(Sections, (nullptr), "Loft", App::Prop_None, "List of sections");
Sections.setSize(0);
- ADD_PROPERTY_TYPE(Solid, (false), "Loft", App::Prop_None, "Create solid");
+ ADD_PROPERTY_TYPE(Solid, (true), "Loft", App::Prop_None, "Create solid");
ADD_PROPERTY_TYPE(Ruled, (false), "Loft", App::Prop_None, "Ruled surface");
ADD_PROPERTY_TYPE(Closed, (false), "Loft", App::Prop_None, "Close Last to First Profile");
ADD_PROPERTY_TYPE(MaxDegree, (5), "Loft", App::Prop_None, "Maximum Degree");
@@ -257,7 +257,7 @@ Sweep::Sweep()
ADD_PROPERTY_TYPE(Sections, (nullptr), "Sweep", App::Prop_None, "List of sections");
Sections.setSize(0);
ADD_PROPERTY_TYPE(Spine, (nullptr), "Sweep", App::Prop_None, "Path to sweep along");
- ADD_PROPERTY_TYPE(Solid, (false), "Sweep", App::Prop_None, "Create solid");
+ ADD_PROPERTY_TYPE(Solid, (true), "Sweep", App::Prop_None, "Create solid");
ADD_PROPERTY_TYPE(Frenet, (true), "Sweep", App::Prop_None, "Frenet");
ADD_PROPERTY_TYPE(Transition, (long(1)), "Sweep", App::Prop_None, "Transition mode");
ADD_PROPERTY_TYPE(Linearize,(false), "Sweep", App::Prop_None,
diff --git a/src/Mod/Part/Gui/TaskLoft.ui b/src/Mod/Part/Gui/TaskLoft.ui
index d47c1ebff1..2b9178aa95 100644
--- a/src/Mod/Part/Gui/TaskLoft.ui
+++ b/src/Mod/Part/Gui/TaskLoft.ui
@@ -22,6 +22,9 @@
Create solid
+
+ true
+
-
diff --git a/src/Mod/Part/Gui/TaskSweep.ui b/src/Mod/Part/Gui/TaskSweep.ui
index 3b2ee55c37..cc563b59d9 100644
--- a/src/Mod/Part/Gui/TaskSweep.ui
+++ b/src/Mod/Part/Gui/TaskSweep.ui
@@ -52,6 +52,9 @@
Create solid
+
+ true
+
-
diff --git a/tests/src/Mod/Part/App/PartFeatures.cpp b/tests/src/Mod/Part/App/PartFeatures.cpp
index 550a478356..d5f07f8e6c 100644
--- a/tests/src/Mod/Part/App/PartFeatures.cpp
+++ b/tests/src/Mod/Part/App/PartFeatures.cpp
@@ -106,6 +106,7 @@ TEST_F(PartFeaturesTest, testSweep)
auto _sweep = _doc->addObject();
_sweep->Sections.setValues({_plane1});
_sweep->Spine.setValue(_edge1);
+ _sweep->Solid.setValue((false));
// Act
_sweep->execute();
TopoShape ts = _sweep->Shape.getShape();