PVS: V595 A pointer was utilized before it was verified against nullptr

This commit is contained in:
wmayer
2020-07-17 17:03:50 +02:00
parent 93f61a3154
commit 473553a212
7 changed files with 27 additions and 24 deletions

View File

@@ -318,9 +318,7 @@ void CmdTechDrawView::activated(int iMsg)
}
//not a Link and not null. assume to be drawable. Undrawables will be
// skipped later.
if (obj != nullptr) {
shapes.push_back(obj);
}
shapes.push_back(obj);
if(partObj != nullptr) {
continue;
}
@@ -576,9 +574,7 @@ void CmdTechDrawProjectionGroup::activated(int iMsg)
}
//not a Link and not null. assume to be drawable. Undrawables will be
// skipped later.
if (obj != nullptr) {
shapes.push_back(obj);
}
shapes.push_back(obj);
if(partObj != nullptr) {
continue;
}

View File

@@ -289,8 +289,8 @@ void QGEPath::clearMarkers()
return;
}
for (auto& m: m_markers) {
m->hide();
if (m != nullptr) {
m->hide();
QGraphicsScene* s = m->scene();
if (s != nullptr) {
s->removeItem(m); //should this be setParentItem(nullptr) instead??