From 473d11fcc64582905b6385a88260257f552e7cdb Mon Sep 17 00:00:00 2001 From: Ajinkya Dahale Date: Sun, 21 Jan 2024 23:27:56 +0530 Subject: [PATCH] [planegcs] Remove some numerical testing If needed this can be moved to a gtest, --- src/Mod/Sketcher/App/planegcs/Constraints.cpp | 36 ------------------- 1 file changed, 36 deletions(-) diff --git a/src/Mod/Sketcher/App/planegcs/Constraints.cpp b/src/Mod/Sketcher/App/planegcs/Constraints.cpp index b670dc1b3f..f99bfbb69d 100644 --- a/src/Mod/Sketcher/App/planegcs/Constraints.cpp +++ b/src/Mod/Sketcher/App/planegcs/Constraints.cpp @@ -2745,24 +2745,6 @@ double ConstraintAngleViaPointAndParam::grad(double* param) deriv -= ((-n1.dx) * n1.y / pow(n1.length(), 2) + n1.dy * n1.x / pow(n1.length(), 2)); deriv += ((-n2.dx) * n2.y / pow(n2.length(), 2) + n2.dy * n2.x / pow(n2.length(), 2)); - -// use numeric for testing -#if 0 - double const eps = 0.00001; - double oldparam = *param; - double v0 = this->error(); - *param += eps; - double vr = this->error(); - *param = oldparam - eps; - double vl = this->error(); - *param = oldparam; - //If not nasty, real derivative should be between left one and right one - double numretl = (v0-vl)/eps; - double numretr = (vr-v0)/eps; - assert(deriv <= std::max(numretl,numretr) ); - assert(deriv >= std::min(numretl,numretr) ); -#endif - return scale * deriv; } @@ -2864,24 +2846,6 @@ double ConstraintAngleViaPointAndTwoParams::grad(double* param) deriv -= ((-n1.dx) * n1.y / pow(n1.length(), 2) + n1.dy * n1.x / pow(n1.length(), 2)); deriv += ((-n2.dx) * n2.y / pow(n2.length(), 2) + n2.dy * n2.x / pow(n2.length(), 2)); - -// use numeric for testing -#if 0 - double const eps = 0.00001; - double oldparam = *param; - double v0 = this->error(); - *param += eps; - double vr = this->error(); - *param = oldparam - eps; - double vl = this->error(); - *param = oldparam; - //If not nasty, real derivative should be between left one and right one - double numretl = (v0-vl)/eps; - double numretr = (vr-v0)/eps; - assert(deriv <= std::max(numretl,numretr) ); - assert(deriv >= std::min(numretl,numretr) ); -#endif - return scale * deriv; }