From 48a1db8a761116045bb822c2ef0e6fe1a66c8d12 Mon Sep 17 00:00:00 2001
From: Ajinkya Dahale <AjinkyaDahale@users.noreply.github.com>
Date: Tue, 21 Nov 2023 20:05:28 +0530
Subject: [PATCH] [PD] Fix wrong mode options when opening existing revolution

Only the "Dimension" options showed regardless of what mode was selected.
---
 src/Mod/PartDesign/Gui/TaskRevolutionParameters.cpp | 5 ++---
 src/Mod/PartDesign/Gui/TaskRevolutionParameters.h   | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/Mod/PartDesign/Gui/TaskRevolutionParameters.cpp b/src/Mod/PartDesign/Gui/TaskRevolutionParameters.cpp
index 6db855f57f..d494d3d459 100644
--- a/src/Mod/PartDesign/Gui/TaskRevolutionParameters.cpp
+++ b/src/Mod/PartDesign/Gui/TaskRevolutionParameters.cpp
@@ -86,7 +86,7 @@ TaskRevolutionParameters::TaskRevolutionParameters(PartDesignGui::ViewProvider*
     setupDialog();
 
     blockUpdate = false;
-    updateUI();
+    updateUI(ui->changeMode->currentIndex());
     connectSignals();
 
     setFocus();
@@ -351,7 +351,6 @@ void TaskRevolutionParameters::onSelectionChanged(const Gui::SelectionChanges& m
                 propReferenceAxis->setValue(selObj, axis);
 
                 recomputeFeature();
-                updateUI();
             }
         }
     }
@@ -546,7 +545,7 @@ void TaskRevolutionParameters::onModeChanged(int index)
         break;
     case PartDesign::Revolution::RevolMethod::ToLast:
         if (!isGroove)
-        pcType->setValue("UpToLast");
+            pcType->setValue("UpToLast");
         else
             pcType->setValue("ThroughAll");
         break;
diff --git a/src/Mod/PartDesign/Gui/TaskRevolutionParameters.h b/src/Mod/PartDesign/Gui/TaskRevolutionParameters.h
index c00d7819b2..8f5ccc87f1 100644
--- a/src/Mod/PartDesign/Gui/TaskRevolutionParameters.h
+++ b/src/Mod/PartDesign/Gui/TaskRevolutionParameters.h
@@ -92,7 +92,7 @@ protected:
 
 private:
     void connectSignals();
-    void updateUI(int index=0); // TODO: Implement for index and remove default
+    void updateUI(int index);
     void translateModeList(int index);
     // TODO: This is common with extrude. Maybe send to superclass.
     void translateFaceName();