From 48d10b25b262c32022cc54fafbd7e47c810074c3 Mon Sep 17 00:00:00 2001 From: Russell Johnson <47639332+Russ4262@users.noreply.github.com> Date: Tue, 17 Aug 2021 21:21:58 -0500 Subject: [PATCH] Path: LGTM fix Prompted by LuzPaz in Gitter.im/FreeCAD/Path chatroom --- src/Mod/Path/PathScripts/PathMillFace.py | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/Mod/Path/PathScripts/PathMillFace.py b/src/Mod/Path/PathScripts/PathMillFace.py index f3c1d93511..2f1928b553 100644 --- a/src/Mod/Path/PathScripts/PathMillFace.py +++ b/src/Mod/Path/PathScripts/PathMillFace.py @@ -265,16 +265,9 @@ class ObjectFace(PathPocketBase.ObjectPocket): eYMax = env.BoundBox.YMax eZMin = faceZ - def isOverlap(fMn, fMx, eMn, eMx): - if fMx > eMn: - if fMx <= eMx: - return True - elif fMx >= eMx and fMn <= eMx: - return True - if fMn < eMx: - if fMn >= eMn: - return True - elif fMn <= eMn and fMx >= eMn: + def isOverlap(faceMin, faceMax, envMin, envMax): + if faceMax > envMin: + if faceMin <= envMax or faceMin == envMin: return True return False