Detect circular references in sketches, and add corresponding tests (#11716)

* Possible fix for 10482 circular reference regression with tests

* Remove redundant test

* Cleanup pre PR

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This commit is contained in:
bgbsww
2024-01-06 19:13:44 -05:00
committed by GitHub
parent d9017bcca3
commit 494cb9388c
3 changed files with 40 additions and 4 deletions

View File

@@ -1725,8 +1725,6 @@ Py::Object ObjectIdentifier::access(const ResolveResults &result,
else if(lastObj) {
const char *attr = components[idx].getName().c_str();
auto prop = lastObj->getPropertyByName(attr);
if(!prop && !pyobj.hasAttr(attr))
attr = nullptr;
setPropDep(lastObj,prop,attr);
lastObj = nullptr;
}