From 4a47b98b1648cddbf0d7069384ca1ecddecef3f3 Mon Sep 17 00:00:00 2001 From: wmayer Date: Tue, 28 Sep 2021 15:43:25 +0200 Subject: [PATCH] PD: [skip ci] fix minor issues: * don't need to clear an empty vector * remove two code blocks that effectively do nothing (except of producing a warning :) ) --- src/Mod/PartDesign/Gui/TaskPadParameters.cpp | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/Mod/PartDesign/Gui/TaskPadParameters.cpp b/src/Mod/PartDesign/Gui/TaskPadParameters.cpp index 941b600781..7b012b25de 100644 --- a/src/Mod/PartDesign/Gui/TaskPadParameters.cpp +++ b/src/Mod/PartDesign/Gui/TaskPadParameters.cpp @@ -355,7 +355,6 @@ void TaskPadParameters::fillDirectionCombo() if (axesInList.empty()) { ui->directionCB->clear(); - this->axesInList.clear(); // add sketch normal PartDesign::ProfileBased* pcFeat = static_cast(vp->getObject()); Part::Part2DObject* pcSketch = dynamic_cast(pcFeat->Profile.getValue()); @@ -414,12 +413,6 @@ void TaskPadParameters::onDirectionCBChanged(int num) if (axesInList.empty() || !pcPad) return; - App::DocumentObject* oldRefAxis = propReferenceAxis->getValue(); - std::vector oldSubRefAxis = propReferenceAxis->getSubValues(); - std::string oldRefName; - if (!oldSubRefAxis.empty()) - oldRefName = oldSubRefAxis.front(); - App::PropertyLinkSub& lnk = *(axesInList[num]); if (lnk.getValue() == 0) { // enter reference selection mode @@ -440,12 +433,6 @@ void TaskPadParameters::onDirectionCBChanged(int num) } try { - App::DocumentObject* newRefAxis = propReferenceAxis->getValue(); - const std::vector& newSubRefAxis = propReferenceAxis->getSubValues(); - std::string newRefName; - if (!newSubRefAxis.empty()) - newRefName = newSubRefAxis.front(); - recomputeFeature(); } catch (const Base::Exception& e) {