From 4bbdfb5f7b17b45e07a15151ea860051ef8049dc Mon Sep 17 00:00:00 2001 From: wmayer Date: Fri, 17 Jul 2020 19:30:13 +0200 Subject: [PATCH] PVS: V768 The expression is of enum type. It is odd that it is used as an expression of a Boolean-type. --- src/Gui/ViewProviderPythonFeature.h | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/Gui/ViewProviderPythonFeature.h b/src/Gui/ViewProviderPythonFeature.h index 71bd6ff0c1..3605f79179 100644 --- a/src/Gui/ViewProviderPythonFeature.h +++ b/src/Gui/ViewProviderPythonFeature.h @@ -503,10 +503,9 @@ protected: ViewProviderT::DisplayMode.touch(); ViewProviderT::setOverrideMode(viewerMode); } - if(!this->testStatus(Gui::isRestoring) && - ViewProviderT::canAddToSceneGraph() && - !imp->canAddToSceneGraph()) - { + if (!this->testStatus(Gui::isRestoring) && + ViewProviderT::canAddToSceneGraph() && + imp->canAddToSceneGraph() == ViewProviderPythonFeatureImp::NotImplemented) { this->getDocument()->toggleInSceneGraph(this); } ViewProviderT::updateView(); @@ -540,11 +539,11 @@ protected: } } virtual void setEditViewer(View3DInventorViewer *viewer, int ModNum) override { - if(!imp->setEditViewer(viewer,ModNum)) + if (imp->setEditViewer(viewer,ModNum) == ViewProviderPythonFeatureImp::NotImplemented) ViewProviderT::setEditViewer(viewer,ModNum); } virtual void unsetEditViewer(View3DInventorViewer *viewer) override { - if(!imp->unsetEditViewer(viewer)) + if (imp->unsetEditViewer(viewer) == ViewProviderPythonFeatureImp::NotImplemented) ViewProviderT::unsetEditViewer(viewer); }