diff --git a/src/Mod/Draft/draftguitools/gui_array_simple.py b/src/Mod/Draft/draftguitools/gui_array_simple.py index 37a3bf9070..3d2ddd26b2 100644 --- a/src/Mod/Draft/draftguitools/gui_array_simple.py +++ b/src/Mod/Draft/draftguitools/gui_array_simple.py @@ -79,16 +79,14 @@ class Array(gui_base_original.Modifier): if self.ui: self.ui.selectUi() _msg(translate("draft", "Select an object to array")) - self.call = \ - self.view.addEventCallback("SoEvent", - gui_tool_utils.selectObject) + self.call = self.view.addEventCallback( + "SoEvent", + gui_tool_utils.selectObject) else: self.proceed() def proceed(self): """Proceed with the command if one object was selected.""" - if self.call: - self.view.removeEventCallback("SoEvent", self.call) if Gui.Selection.getSelection(): obj = Gui.Selection.getSelection()[0] Gui.addModule("Draft") diff --git a/src/Mod/Draft/draftguitools/gui_clone.py b/src/Mod/Draft/draftguitools/gui_clone.py index bbe1be68f8..1901c5c4e5 100644 --- a/src/Mod/Draft/draftguitools/gui_clone.py +++ b/src/Mod/Draft/draftguitools/gui_clone.py @@ -80,17 +80,14 @@ class Clone(gui_base_original.Modifier): if self.ui: self.ui.selectUi() _msg(translate("draft", "Select an object to clone")) - self.call = \ - self.view.addEventCallback("SoEvent", - gui_tool_utils.selectObject) + self.call = self.view.addEventCallback( + "SoEvent", + gui_tool_utils.selectObject) else: self.proceed() def proceed(self): """Proceed with the command if one object was selected.""" - if self.call: - self.view.removeEventCallback("SoEvent", self.call) - if Gui.Selection.getSelection(): sels = len(Gui.Selection.getSelection()) Gui.addModule("Draft") diff --git a/src/Mod/Draft/draftguitools/gui_downgrade.py b/src/Mod/Draft/draftguitools/gui_downgrade.py index 4bc95bf053..dbc056165f 100644 --- a/src/Mod/Draft/draftguitools/gui_downgrade.py +++ b/src/Mod/Draft/draftguitools/gui_downgrade.py @@ -71,17 +71,14 @@ class Downgrade(gui_base_original.Modifier): if not Gui.Selection.getSelection(): self.ui.selectUi() _msg(translate("draft", "Select an object to upgrade")) - self.call = \ - self.view.addEventCallback("SoEvent", - gui_tool_utils.selectObject) + self.call = self.view.addEventCallback( + "SoEvent", + gui_tool_utils.selectObject) else: self.proceed() def proceed(self): """Proceed with execution of the command after selection.""" - if self.call: - self.view.removeEventCallback("SoEvent", self.call) - if Gui.Selection.getSelection(): Gui.addModule("Draft") _cmd = 'Draft.downgrade' diff --git a/src/Mod/Draft/draftguitools/gui_draft2sketch.py b/src/Mod/Draft/draftguitools/gui_draft2sketch.py index 6deac33000..d5311d7dbb 100644 --- a/src/Mod/Draft/draftguitools/gui_draft2sketch.py +++ b/src/Mod/Draft/draftguitools/gui_draft2sketch.py @@ -71,17 +71,14 @@ class Draft2Sketch(gui_base_original.Modifier): if self.ui: self.ui.selectUi() _msg(translate("draft", "Select an object to convert.")) - self.call = \ - self.view.addEventCallback("SoEvent", - gui_tool_utils.selectObject) + self.call = self.view.addEventCallback( + "SoEvent", + gui_tool_utils.selectObject) else: self.proceed() def proceed(self): """Proceed with the command if one object was selected.""" - if self.call: - self.view.removeEventCallback("SoEvent", self.call) - sel = Gui.Selection.getSelection() allSketches = True allDraft = True diff --git a/src/Mod/Draft/draftguitools/gui_facebinders.py b/src/Mod/Draft/draftguitools/gui_facebinders.py index 0f78eb739f..7f1879c61b 100644 --- a/src/Mod/Draft/draftguitools/gui_facebinders.py +++ b/src/Mod/Draft/draftguitools/gui_facebinders.py @@ -70,16 +70,14 @@ class Facebinder(gui_base_original.Creator): if self.ui: self.ui.selectUi() _msg(translate("draft", "Select faces from existing objects")) - self.call = \ - self.view.addEventCallback("SoEvent", - gui_tool_utils.selectObject) + self.call = self.view.addEventCallback( + "SoEvent", + gui_tool_utils.selectObject) else: self.proceed() def proceed(self): """Proceed when a valid selection has been made.""" - if self.call: - self.view.removeEventCallback("SoEvent", self.call) if Gui.Selection.getSelection(): App.ActiveDocument.openTransaction("Create Facebinder") Gui.addModule("Draft") diff --git a/src/Mod/Draft/draftguitools/gui_join.py b/src/Mod/Draft/draftguitools/gui_join.py index 12034a9635..62cfcb5919 100644 --- a/src/Mod/Draft/draftguitools/gui_join.py +++ b/src/Mod/Draft/draftguitools/gui_join.py @@ -78,8 +78,9 @@ class Join(gui_base_original.Modifier): if not Gui.Selection.getSelection(): self.ui.selectUi() _msg(translate("draft", "Select an object to join")) - self.call = self.view.addEventCallback("SoEvent", - gui_tool_utils.selectObject) + self.call = self.view.addEventCallback( + "SoEvent", + gui_tool_utils.selectObject) else: self.proceed() @@ -90,8 +91,6 @@ class Join(gui_base_original.Modifier): visually share a point. This is due to the underlying `joinWires` method not handling the points correctly. """ - if self.call: - self.view.removeEventCallback("SoEvent", self.call) if Gui.Selection.getSelection(): self.print_selection() Gui.addModule("Draft") diff --git a/src/Mod/Draft/draftguitools/gui_offset.py b/src/Mod/Draft/draftguitools/gui_offset.py index 58960b9a9f..86e21b044d 100644 --- a/src/Mod/Draft/draftguitools/gui_offset.py +++ b/src/Mod/Draft/draftguitools/gui_offset.py @@ -78,9 +78,9 @@ class Offset(gui_base_original.Modifier): if not Gui.Selection.getSelection(): self.ui.selectUi() _msg(translate("draft", "Select an object to offset")) - self.call = \ - self.view.addEventCallback("SoEvent", - gui_tool_utils.selectObject) + self.call = self.view.addEventCallback( + "SoEvent", + gui_tool_utils.selectObject) elif len(Gui.Selection.getSelection()) > 1: _wrn(translate("draft", "Offset only works " "on one object at a time.")) diff --git a/src/Mod/Draft/draftguitools/gui_patharray.py b/src/Mod/Draft/draftguitools/gui_patharray.py index c025668901..15a3d32448 100644 --- a/src/Mod/Draft/draftguitools/gui_patharray.py +++ b/src/Mod/Draft/draftguitools/gui_patharray.py @@ -103,9 +103,6 @@ class PathArray(gui_base_original.Modifier): def proceed(self): """Proceed with the command if one object was selected.""" - if self.call: - self.view.removeEventCallback("SoEvent", self.call) - sel = Gui.Selection.getSelectionEx() if len(sel) != 2: _err(_tr("Please select exactly two objects, " diff --git a/src/Mod/Draft/draftguitools/gui_pathtwistedarray.py b/src/Mod/Draft/draftguitools/gui_pathtwistedarray.py index 0275258648..daf0e81660 100644 --- a/src/Mod/Draft/draftguitools/gui_pathtwistedarray.py +++ b/src/Mod/Draft/draftguitools/gui_pathtwistedarray.py @@ -80,9 +80,6 @@ class PathTwistedArray(gui_base_original.Modifier): def proceed(self): """Proceed with the command if one object was selected.""" - if self.call: - self.view.removeEventCallback("SoEvent", self.call) - sel = Gui.Selection.getSelectionEx() if len(sel) != 2: _err(_tr("Please select exactly two objects, " diff --git a/src/Mod/Draft/draftguitools/gui_pointarray.py b/src/Mod/Draft/draftguitools/gui_pointarray.py index 49efd09ade..7057afeb6c 100644 --- a/src/Mod/Draft/draftguitools/gui_pointarray.py +++ b/src/Mod/Draft/draftguitools/gui_pointarray.py @@ -113,9 +113,6 @@ class PointArray(gui_base_original.Modifier): def proceed(self): """Proceed with the command if one object was selected.""" - if self.call: - self.view.removeEventCallback("SoEvent", self.call) - sel = Gui.Selection.getSelectionEx() if len(sel) != 2: _err(_tr("Please select exactly two objects, " diff --git a/src/Mod/Draft/draftguitools/gui_shape2dview.py b/src/Mod/Draft/draftguitools/gui_shape2dview.py index c1fcc97b15..fca56f6af7 100644 --- a/src/Mod/Draft/draftguitools/gui_shape2dview.py +++ b/src/Mod/Draft/draftguitools/gui_shape2dview.py @@ -75,17 +75,14 @@ class Shape2DView(gui_base_original.Modifier): if self.ui: self.ui.selectUi() _msg(translate("draft", "Select an object to project")) - self.call = \ - self.view.addEventCallback("SoEvent", - gui_tool_utils.selectObject) + self.call = self.view.addEventCallback( + "SoEvent", + gui_tool_utils.selectObject) else: self.proceed() def proceed(self): """Proceed with the command if one object was selected.""" - if self.call: - self.view.removeEventCallback("SoEvent", self.call) - faces = [] objs = [] vec = Gui.ActiveDocument.ActiveView.getViewDirection().negative() diff --git a/src/Mod/Draft/draftguitools/gui_split.py b/src/Mod/Draft/draftguitools/gui_split.py index 880804611e..70f009335f 100644 --- a/src/Mod/Draft/draftguitools/gui_split.py +++ b/src/Mod/Draft/draftguitools/gui_split.py @@ -112,8 +112,6 @@ class Split(gui_base_original.Modifier): self.commit(translate("draft", "Split line"), _cmd_list) - if self.call: - self.view.removeEventCallback("SoEvent", self.call) self.finish() diff --git a/src/Mod/Draft/draftguitools/gui_upgrade.py b/src/Mod/Draft/draftguitools/gui_upgrade.py index 18acc0cf51..088f02721c 100644 --- a/src/Mod/Draft/draftguitools/gui_upgrade.py +++ b/src/Mod/Draft/draftguitools/gui_upgrade.py @@ -73,17 +73,14 @@ class Upgrade(gui_base_original.Modifier): if not Gui.Selection.getSelection(): self.ui.selectUi() _msg(translate("draft", "Select an object to upgrade")) - self.call = \ - self.view.addEventCallback("SoEvent", - gui_tool_utils.selectObject) + self.call = self.view.addEventCallback( + "SoEvent", + gui_tool_utils.selectObject) else: self.proceed() def proceed(self): """Proceed with execution of the command after selection.""" - if self.call: - self.view.removeEventCallback("SoEvent", self.call) - if Gui.Selection.getSelection(): Gui.addModule("Draft") _cmd = 'Draft.upgrade'