From 4e27d4eebe566c03c38ff49ef76854a978092ea2 Mon Sep 17 00:00:00 2001 From: Ladislav Michl Date: Tue, 26 Aug 2025 19:26:04 +0200 Subject: [PATCH] Gui: fix 'Minimum fractional inch' preference visibility Default Unit Schema is not yet changed in onUnitSystemIndexChanged callback handler, so index needs to be used to request currently selected one. Fixes: 1155f0d75281 ("Base: simplify UnitsSchemas management") --- src/Base/UnitsSchema.h | 2 +- src/Gui/PreferencePages/DlgSettingsGeneral.cpp | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Base/UnitsSchema.h b/src/Base/UnitsSchema.h index 6587d5359b..6a459bc520 100644 --- a/src/Base/UnitsSchema.h +++ b/src/Base/UnitsSchema.h @@ -36,7 +36,7 @@ class Quantity; /** * An individual schema object */ -class UnitsSchema +class BaseExport UnitsSchema { public: explicit UnitsSchema(UnitsSchemaSpec spec); diff --git a/src/Gui/PreferencePages/DlgSettingsGeneral.cpp b/src/Gui/PreferencePages/DlgSettingsGeneral.cpp index 48755f9f50..c668f5f38b 100644 --- a/src/Gui/PreferencePages/DlgSettingsGeneral.cpp +++ b/src/Gui/PreferencePages/DlgSettingsGeneral.cpp @@ -749,7 +749,8 @@ void DlgSettingsGeneral::onUnitSystemIndexChanged(const int index) } // Enable/disable the fractional inch option depending on system - const auto visible = UnitsApi::isMultiUnitLength(); + const auto schema = UnitsApi::createSchema(index); + const auto visible = schema->isMultiUnitLength(); ui->comboBox_FracInch->setVisible(visible); ui->fractionalInchLabel->setVisible(visible); }