From 4e36cde00af75fb69d56f15e29102201e5e630a3 Mon Sep 17 00:00:00 2001 From: paul lee Date: Sun, 19 Jul 2020 08:47:54 +0800 Subject: [PATCH] [ArchWall] Failed if Sketch as Base has Point, now OK FC Forum Discussion - https://forum.freecadweb.org/viewtopic.php?f=23&t=48668&sid=ba6dd68ad32eefbad6ae95d8fadc30e6#p416779 --- src/Mod/Arch/ArchWall.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/Mod/Arch/ArchWall.py b/src/Mod/Arch/ArchWall.py index d624dac8be..83b31711a0 100644 --- a/src/Mod/Arch/ArchWall.py +++ b/src/Mod/Arch/ArchWall.py @@ -1243,8 +1243,10 @@ class _Wall(ArchComponent.Component): skPlacement = obj.Base.Placement # Get Sketch's placement to restore later for i in skGeom: if not i.Construction: - skGeomEdgesI = i.toShape() - skGeomEdges.append(skGeomEdgesI) + # support Line, Arc, Circle for Sketch as Base at the moment + if isinstance(i, (Part.LineSegment, Part.Circle, Part.ArcOfCircle)): + skGeomEdgesI = i.toShape() + skGeomEdges.append(skGeomEdgesI) for cluster in Part.getSortedClusters(skGeomEdges): clusterTransformed = [] for edge in cluster: @@ -1269,9 +1271,9 @@ class _Wall(ArchComponent.Component): # bug - e.g. a Dwire with edges/vertexes in clockwise # order, 1st vertex is Forward as expected. After # sorting below, edges sorted still in clockwise order - # - no problem, vertexes still in clocwise order - no - # problem, but 1st vertex of each edge become Reverse - # rather than Forward. + # - no problem, but 1st vertex of each edge become + # Reverse rather than Forward. + # See FC discussion - # https://forum.freecadweb.org/viewtopic.php?f=23&t=48275&p=413745#p413745