From 4f324add9f27447110445b29df9d0300758541a2 Mon Sep 17 00:00:00 2001
From: Uwe <donovaly@users.noreply.github.com>
Date: Mon, 27 Feb 2023 00:30:56 +0100
Subject: [PATCH] [App] attempt to fix compiler warnings in Property.h

- "conversion from 'size_t' to 'int', possible loss of data" in for loops by modernizing the for loops
- fix warning about uninitialized variable
---
 src/App/Property.h | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/src/App/Property.h b/src/App/Property.h
index dd7d879eea..058a036f35 100644
--- a/src/App/Property.h
+++ b/src/App/Property.h
@@ -550,24 +550,31 @@ public:
 
 protected:
 
-    void setPyValues(const std::vector<PyObject*> &vals, const std::vector<int> &indices) override 
+    void setPyValues(const std::vector<PyObject*>& vals, const std::vector<int>& indices) override
     {
+        int i = 0;
         if (indices.empty()) {
-            ListT values;
+            ListT values {};
             values.resize(vals.size());
-            for (std::size_t i=0,count=vals.size();i<count;++i)
-                values[i] = getPyValue(vals[i]);
+            i = 0;
+            for (auto valsContent : vals) {
+                values[i] = getPyValue(valsContent);
+                i++;
+            }
             setValues(std::move(values));
             return;
         }
-        assert(vals.size()==indices.size());
+        assert(vals.size() == indices.size());
         atomic_change guard(*this);
-        for (int i=0,count=indices.size();i<count;++i)
-            set1Value(indices[i],getPyValue(vals[i]));
+        i = 0;
+        for (auto index : indices) {
+            set1Value(index, getPyValue(vals[i]));
+            i++;
+        }
         guard.tryInvoke();
     }
 
-    virtual T getPyValue(PyObject *item) const = 0;
+    virtual T getPyValue(PyObject* item) const = 0;
 
 protected:
     ListT _lValueList;