kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Base: fix incorrect method names of Matrix class about diagonal and trace

Browse Source
This commit is contained in:
wmayer
2023-08-29 15:12:18 +02:00
committed by wwmayer
parent 939984bf2c
commit 4f6ab508d7
5 changed files with 36 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/src/Base/Matrix.cpp
View File

@@ -1,7 +1,8 @@
#include "gtest/gtest.h"
#include <Base/Matrix.h>
#include <Base/Rotation.h>
// NOLINTBEGIN(cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers)
// NOLINTBEGIN(cppcoreguidelines-*,readability-magic-numbers)
// clang-format off
TEST(Matrix, TestShearing)
{
@@ -87,12 +88,12 @@ TEST(Matrix, TestNonUniformScaleLeftTwo)
EXPECT_EQ(mat.hasScale(), Base::ScaleType::Uniform);
}
TEST(Matrix, TestTrace)
TEST(Matrix, TestDiagonal)
{
Base::Matrix4D mat;
mat.scale(2.0, 2.0, 2.0);
Base::Vector3d trace = mat.trace();
EXPECT_EQ(trace.x + trace.y + trace.z, 6.0);
Base::Vector3d diag = mat.diagonal();
EXPECT_EQ(diag.x + diag.y + diag.z, 6.0);
}
TEST(Matrix, TestColRow)
@@ -264,4 +265,4 @@ TEST(Matrix, TestSubAssign)
EXPECT_EQ(mat1, mat4);
}
// clang-format on
// NOLINTEND(cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers)
// NOLINTEND(cppcoreguidelines-*,readability-magic-numbers)