From 4f9bf0e72ecbc98c41a73c2afd924cb56af0a576 Mon Sep 17 00:00:00 2001
From: wandererfan <wandererfan@gmail.com>
Date: Sat, 22 Feb 2025 17:58:39 -0500
Subject: [PATCH] [TD]change scaling default for Draft & BIM views

---
 src/Mod/TechDraw/Gui/ViewProviderSymbol.cpp | 14 ++++----------
 src/Mod/TechDraw/Gui/ViewProviderSymbol.h   | 15 +++++++++++----
 2 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/src/Mod/TechDraw/Gui/ViewProviderSymbol.cpp b/src/Mod/TechDraw/Gui/ViewProviderSymbol.cpp
index d41d311588..4dadf03991 100644
--- a/src/Mod/TechDraw/Gui/ViewProviderSymbol.cpp
+++ b/src/Mod/TechDraw/Gui/ViewProviderSymbol.cpp
@@ -49,10 +49,6 @@ ViewProviderSymbol::ViewProviderSymbol()
 
 }
 
-ViewProviderSymbol::~ViewProviderSymbol()
-{
-}
-
 void ViewProviderSymbol::updateData(const App::Property* prop)
 {
     TechDraw::DrawViewSymbol *obj = getViewObject();
@@ -92,11 +88,10 @@ PROPERTY_SOURCE(TechDrawGui::ViewProviderDraft, TechDrawGui::ViewProviderSymbol)
 ViewProviderDraft::ViewProviderDraft()
 {
     sPixmap = "actions/TechDraw_DraftView.svg";
+    // svg files from Draft/BIM arrive in old scale
+    LegacyScaling.setValue(true);
 }
 
-ViewProviderDraft::~ViewProviderDraft()
-{
-}
 
 //**************************************************************************
 // Arch view
@@ -107,8 +102,7 @@ PROPERTY_SOURCE(TechDrawGui::ViewProviderArch, TechDrawGui::ViewProviderSymbol)
 ViewProviderArch::ViewProviderArch()
 {
     sPixmap = "actions/TechDraw_ArchView.svg";
+    // svg files from Draft/BIM arrive in old scale
+    LegacyScaling.setValue(true);
 }
 
-ViewProviderArch::~ViewProviderArch()
-{
-}
diff --git a/src/Mod/TechDraw/Gui/ViewProviderSymbol.h b/src/Mod/TechDraw/Gui/ViewProviderSymbol.h
index 67e31603ab..fa16bd498e 100644
--- a/src/Mod/TechDraw/Gui/ViewProviderSymbol.h
+++ b/src/Mod/TechDraw/Gui/ViewProviderSymbol.h
@@ -33,45 +33,52 @@
 
 namespace TechDrawGui {
 
+//NOLINTBEGIN
 class TechDrawGuiExport ViewProviderSymbol : public ViewProviderDrawingView
 {
     PROPERTY_HEADER_WITH_OVERRIDE(TechDrawGui::ViewProviderSymbol);
+//NOLINTEND
 
 public:
     /// constructor
     ViewProviderSymbol();
     /// destructor
-    ~ViewProviderSymbol() override;
+    ~ViewProviderSymbol() override  = default ;
 
     App::PropertyBool LegacyScaling;
 
     bool useNewSelectionModel() const override {return false;}
-    void updateData(const App::Property*) override;
+    void updateData(const App::Property* prop) override;
     void onChanged(const App::Property* prop) override;
 
     TechDraw::DrawViewSymbol* getViewObject() const override;
 };
 
+//NOLINTBEGIN
 class TechDrawGuiExport ViewProviderDraft : public ViewProviderSymbol
 {
     PROPERTY_HEADER_WITH_OVERRIDE(TechDrawGui::ViewProviderDraft);
+//NOLINTEND
 
 public:
     /// constructor
     ViewProviderDraft();
     /// destructor
-    ~ViewProviderDraft() override;
+    ~ViewProviderDraft() override = default ;
 };
 
+
+//NOLINTBEGIN
 class TechDrawGuiExport ViewProviderArch : public ViewProviderSymbol
 {
     PROPERTY_HEADER_WITH_OVERRIDE(TechDrawGui::ViewProviderArch);
+//NOLINTEND
 
 public:
     /// constructor
     ViewProviderArch();
     /// destructor
-    ~ViewProviderArch() override;
+    ~ViewProviderArch() override  = default ;
 };
 
 } // namespace TechDrawGui