From 501b45bac84b5e44d0e78f575cb83663bd479afa Mon Sep 17 00:00:00 2001 From: Uwe Date: Sun, 23 Jan 2022 04:58:58 +0100 Subject: [PATCH] [PD] uniform default Pad/Pocket lengths - the goal of the recent Pad/Pocket code refactoring was to handle Pad and Pocket the same default Pad were 10 long, Pocket only 5 -> uniform this to 10 - the initialization of the length were different than the default set in Command.cpp - it was annoying that the default 2nd length was 10 and 20 times the default for the 1st length -> uniform and take the same than the 1st length --- src/Mod/PartDesign/App/FeaturePad.cpp | 4 ++-- src/Mod/PartDesign/App/FeaturePocket.cpp | 4 ++-- src/Mod/PartDesign/Gui/Command.cpp | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Mod/PartDesign/App/FeaturePad.cpp b/src/Mod/PartDesign/App/FeaturePad.cpp index 72e77dfda0..ce5c1dd546 100644 --- a/src/Mod/PartDesign/App/FeaturePad.cpp +++ b/src/Mod/PartDesign/App/FeaturePad.cpp @@ -66,8 +66,8 @@ Pad::Pad() ADD_PROPERTY_TYPE(Type, (0L), "Pad", App::Prop_None, "Pad type"); Type.setEnums(TypeEnums); - ADD_PROPERTY_TYPE(Length, (100.0), "Pad", App::Prop_None, "Pad length"); - ADD_PROPERTY_TYPE(Length2, (100.0), "Pad", App::Prop_None, "Pad length in 2nd direction"); + ADD_PROPERTY_TYPE(Length, (10.0), "Pad", App::Prop_None, "Pad length"); + ADD_PROPERTY_TYPE(Length2, (10.0), "Pad", App::Prop_None, "Pad length in 2nd direction"); ADD_PROPERTY_TYPE(UseCustomVector, (false), "Pad", App::Prop_None, "Use custom vector for pad direction"); ADD_PROPERTY_TYPE(Direction, (Base::Vector3d(1.0, 1.0, 1.0)), "Pad", App::Prop_None, "Pad direction vector"); ADD_PROPERTY_TYPE(ReferenceAxis, (0), "Pad", App::Prop_None, "Reference axis of direction"); diff --git a/src/Mod/PartDesign/App/FeaturePocket.cpp b/src/Mod/PartDesign/App/FeaturePocket.cpp index 962563f518..30fa839281 100644 --- a/src/Mod/PartDesign/App/FeaturePocket.cpp +++ b/src/Mod/PartDesign/App/FeaturePocket.cpp @@ -65,8 +65,8 @@ Pocket::Pocket() ADD_PROPERTY_TYPE(Type, ((long)0), "Pocket", App::Prop_None, "Pocket type"); Type.setEnums(TypeEnums); - ADD_PROPERTY_TYPE(Length, (100.0), "Pocket", App::Prop_None, "Pocket length"); - ADD_PROPERTY_TYPE(Length2, (100.0), "Pocket", App::Prop_None, "Pocket length in 2nd direction"); + ADD_PROPERTY_TYPE(Length, (10.0), "Pocket", App::Prop_None, "Pocket length"); + ADD_PROPERTY_TYPE(Length2, (10.0), "Pocket", App::Prop_None, "Pocket length in 2nd direction"); ADD_PROPERTY_TYPE(UseCustomVector, (false), "Pocket", App::Prop_None, "Use custom vector for pocket direction"); ADD_PROPERTY_TYPE(Direction, (Base::Vector3d(1.0, 1.0, 1.0)), "Pocket", App::Prop_None, "Pocket direction vector"); ADD_PROPERTY_TYPE(ReferenceAxis, (0), "Pocket", App::Prop_None, "Reference axis of direction"); diff --git a/src/Mod/PartDesign/Gui/Command.cpp b/src/Mod/PartDesign/Gui/Command.cpp index 0d9612d8a3..fd1e371905 100644 --- a/src/Mod/PartDesign/Gui/Command.cpp +++ b/src/Mod/PartDesign/Gui/Command.cpp @@ -1353,7 +1353,7 @@ void CmdPartDesignPocket::activated(int iMsg) if (!PartDesignGui::assureModernWorkflow(doc)) return; - prepareProfileBased(this, "Pocket", 5.0); + prepareProfileBased(this, "Pocket", 10.0); } bool CmdPartDesignPocket::isActive(void)