kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

App: add pure virtual methods to PropertyGeometry to delegate it to the geometry of sub-classes

Browse Source 
Following the law of Demeter add some wrapper methods to PropertyGeometry and implement them in sub-classes. As a side-effect this makes some const_cast obsolete
This commit is contained in:
wmayer
2022-06-24 16:15:02 +02:00
parent f87d9bd626
commit 5234d9bc67
10 changed files with 49 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Mod/Part/App/PartFeature.cpp
View File

@@ -541,14 +541,12 @@ void Feature::onChanged(const App::Property* prop)
{
// if the placement has changed apply the change to the point data as well
if (prop == &this->Placement) {
TopoShape& shape = const_cast<TopoShape&>(this->Shape.getShape());
shape.setTransform(this->Placement.getValue().toMatrix());
this->Shape.setTransform(this->Placement.getValue().toMatrix());
}
// if the point data has changed check and adjust the transformation as well
else if (prop == &this->Shape) {
if (this->isRecomputing()) {
TopoShape& shape = const_cast<TopoShape&>(this->Shape.getShape());
shape.setTransform(this->Placement.getValue().toMatrix());
this->Shape.setTransform(this->Placement.getValue().toMatrix());
}
else {
Base::Placement p;