kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Assembly: Prevent crash when toggling rigid of grounded sub assembly (#24761)

Browse Source 
* Assembly: Prevent crash when toggling rigid of grounded sub assembly

* to squash

* to squash

* Update AssemblyLink.cpp
This commit is contained in:
PaddleStroke
2025-10-21 09:51:15 +02:00
committed by GitHub
parent d97c7cc95c
commit 529aae0238
3 changed files with 31 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/Mod/Assembly/App/AssemblyLink.cpp
View File

@@ -101,6 +101,26 @@ void AssemblyLink::onChanged(const App::Property* prop)
if (prop == &Rigid) {
Base::Placement movePlc;
// A flexible sub-assembly cannot be grounded.
// If a rigid sub-assembly has an object that is grounded, we also remove it.
auto groundedJoints = getParentAssembly()->getGroundedJoints();
for (auto* joint : groundedJoints) {
auto* propObj =
dynamic_cast<App::PropertyLink*>(joint->getPropertyByName("ObjectToGround"));
if (!propObj) {
continue;
}
auto* groundedObj = propObj->getValue();
if (auto* linkElt = dynamic_cast<App::LinkElement*>(groundedObj)) {
// hasObject does not handle link groups so we must handle it manually.
groundedObj = linkElt->getLinkGroup();
}
if (Rigid.getValue() ? hasObject(groundedObj) : groundedObj == this) {
getDocument()->removeObject(joint->getNameInDocument());
}
}
if (Rigid.getValue()) {
// movePlc needs to be computed before updateContents.
App::DocumentObject* firstLink = nullptr;