kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Coverity: [skip ci] Dereference before null check

Browse Source
This commit is contained in:
wmayer
2020-07-21 14:31:09 +02:00
parent 617668a7f2
commit 5584c36c1b
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Mod/TechDraw/Gui/TaskLeaderLine.cpp
View File

@@ -134,8 +134,7 @@ TaskLeaderLine::TaskLeaderLine(TechDrawGui::ViewProviderLeader* leadVP) :
}
//TODO: when/if leaders are allowed to be parented to Page, check for m_baseFeat will be removed
if ( (m_lineFeat == nullptr) ||
(m_baseFeat == nullptr) ||
if ( (m_baseFeat == nullptr) ||
(m_basePage == nullptr) ) {
Base::Console().Error("TaskLeaderLine - bad parameters (2). Can not proceed.\n");
return;
@@ -442,9 +441,9 @@ void TaskLeaderLine::createLeaderFeature(std::vector<Base::Vector3d> converted)
if (m_baseFeat != nullptr) {
m_baseFeat->touch();
}
if (m_basePage != nullptr) {
m_basePage->touch();
}
m_basePage->touch();
if (m_lineFeat != nullptr) {
m_lineFeat->requestPaint();
}