kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PartDesign/Feature: add an optional parameter to getBaseObject() to prevent it from throwing exceptions

Browse Source 
In most cases getBaseObject() is used with an exception handler which
only detects if it failed but not the reason. This modification allows
to use it without excess exception handlers.
Also add the same parameter to SketchBased::getVerifiedSketch().
This commit is contained in:
Alexander Golubev
2015-07-26 09:21:00 +03:00
committed by Stefan Tröger
parent 013381ccb6
commit 55f3f52f54
10 changed files with 121 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/PartDesign/Gui/ViewProvider.cpp
View File

@@ -167,14 +167,8 @@ void ViewProvider::updateData(const App::Property* prop)
bool ViewProvider::onDelete(const std::vector<std::string> &)
{
App::DocumentObject* previous;
PartDesign::Feature* feature = static_cast<PartDesign::Feature*>(getObject());
try {
previous = feature->getBaseObject();
} catch (const Base::Exception &ex) {
previous = 0;
}
App::DocumentObject* previous = feature->getBaseObject(/* silent = */ true );
// Make the tip or the previous feature visiable again with preference to the previous one
// if the feature was visiable itself