From 5782a9429a55d300843849bf459eee468b196328 Mon Sep 17 00:00:00 2001 From: wmayer Date: Mon, 25 Jul 2022 00:19:41 +0200 Subject: [PATCH] Fix several clazy issues: * Returning data of temporary QByteArray [-Wclazy-returning-data-from-temporary] --- src/Gui/DlgPropertyLink.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Gui/DlgPropertyLink.cpp b/src/Gui/DlgPropertyLink.cpp index ded629e71b..4b4c7abddb 100644 --- a/src/Gui/DlgPropertyLink.cpp +++ b/src/Gui/DlgPropertyLink.cpp @@ -672,8 +672,8 @@ void DlgPropertyLink::accept() static QTreeWidgetItem *_getLinkFromItem(std::ostringstream &ss, QTreeWidgetItem *item, const char *objName) { auto parent = item->parent(); assert(parent); - const char *nextName = parent->data(0, Qt::UserRole).toByteArray().constData(); - if(!nextName[0]) + QByteArray nextName = parent->data(0, Qt::UserRole).toByteArray(); + if (nextName.isEmpty()) return item; item = _getLinkFromItem(ss, parent, nextName); @@ -1016,13 +1016,13 @@ void DlgPropertyLink::onItemExpanded(QTreeWidgetItem * item) { if(item->childCount()) return; - const char *docName = item->data(0, Qt::UserRole+1).toByteArray().constData(); + QByteArray docName = item->data(0, Qt::UserRole+1).toByteArray(); auto doc = App::GetApplication().getDocument(docName); - if(!doc) + if (!doc) return; - const char *objName = item->data(0, Qt::UserRole).toByteArray().constData(); - if(!objName[0]) { + QByteArray objName = item->data(0, Qt::UserRole).toByteArray(); + if (objName.isEmpty()) { for(auto obj : doc->getObjects()) { auto newItem = createItem(obj,item); if(newItem)