From 584a1bf44263acb549f5134a77e2859d7ae8a6d5 Mon Sep 17 00:00:00 2001 From: wmayer Date: Sat, 25 Jul 2020 14:48:59 +0200 Subject: [PATCH] LGTM: [skip ci] fix: Resource not released in destructor --- src/Mod/Mesh/Gui/SoFCMeshObject.cpp | 2 +- src/Mod/Mesh/Gui/SoFCMeshObject.h | 2 +- src/Mod/Mesh/Gui/ViewProvider.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Mod/Mesh/Gui/SoFCMeshObject.cpp b/src/Mod/Mesh/Gui/SoFCMeshObject.cpp index f53336feea..03fdcc78b9 100644 --- a/src/Mod/Mesh/Gui/SoFCMeshObject.cpp +++ b/src/Mod/Mesh/Gui/SoFCMeshObject.cpp @@ -167,7 +167,7 @@ private: // Defines all required member variables and functions for a // single-value field -SO_SFIELD_SOURCE(SoSFMeshObject, const Mesh::MeshObject*, const Mesh::MeshObject*) +SO_SFIELD_SOURCE(SoSFMeshObject, Base::Reference, Base::Reference) void SoSFMeshObject::initClass() diff --git a/src/Mod/Mesh/Gui/SoFCMeshObject.h b/src/Mod/Mesh/Gui/SoFCMeshObject.h index af26cb486f..5c1130d474 100644 --- a/src/Mod/Mesh/Gui/SoFCMeshObject.h +++ b/src/Mod/Mesh/Gui/SoFCMeshObject.h @@ -45,7 +45,7 @@ namespace MeshGui { class MeshGuiExport SoSFMeshObject : public SoSField { typedef SoSField inherited; - SO_SFIELD_HEADER(SoSFMeshObject, const Mesh::MeshObject*, const Mesh::MeshObject*); + SO_SFIELD_HEADER(SoSFMeshObject, Base::Reference, Base::Reference); public: static void initClass(void); diff --git a/src/Mod/Mesh/Gui/ViewProvider.cpp b/src/Mod/Mesh/Gui/ViewProvider.cpp index a3bda0036b..449afdf295 100644 --- a/src/Mod/Mesh/Gui/ViewProvider.cpp +++ b/src/Mod/Mesh/Gui/ViewProvider.cpp @@ -2363,7 +2363,7 @@ void ViewProviderMeshObject::updateData(const App::Property* prop) ViewProviderMesh::updateData(prop); if (prop->getTypeId() == Mesh::PropertyMeshKernel::getClassTypeId()) { const Mesh::PropertyMeshKernel* mesh = static_cast(prop); - this->pcMeshNode->mesh.setValue(mesh->getValuePtr()); + this->pcMeshNode->mesh.setValue(Base::Reference(mesh->getValuePtr())); // Needs to update internal bounding box caches this->pcMeshShape->touch(); }