kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sketcher: Trigger elements widget update on toggle/set construction geometry

Browse Source
This commit is contained in:
Abdullah Tahiri
2020-12-24 15:31:42 +01:00
committed by abdullahtahiriyo
parent b6729a41d7
commit 5c8e65728f
1 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/Mod/Sketcher/App/SketchObject.cpp
View File

@@ -1155,12 +1155,10 @@ int SketchObject::toggleConstruction(int GeoId)
}
}
// There is not actual intertransaction going on here, however for a toggle neither the geometry indices nor the vertices need to be updated
// so this is a convenient way of preventing it.
{
Base::StateLocker lock(internaltransaction, true);
this->Geometry.setValues(std::move(newVals));
}
// While it may seem that there is not a need to trigger an update at this time, because the solver has its own copy of the geometry,
// and updateColors of the viewprovider may be triggered by the clearselection of the UI command, this won't update the elements widget,
// in the accumulative of actions it is judged that it is worth to trigger an update here.
this->Geometry.setValues(std::move(newVals));
solverNeedsUpdate=true;
return 0;
@@ -1188,12 +1186,10 @@ int SketchObject::setConstruction(int GeoId, bool on)
}
}
// There is not actual intertransaction going on here, however for a toggle neither the geometry indices nor the vertices need to be updated
// so this is a convenient way of preventing it.
{
Base::StateLocker lock(internaltransaction, true);
this->Geometry.setValues(std::move(newVals));
}
// While it may seem that there is not a need to trigger an update at this time, because the solver has its own copy of the geometry,
// and updateColors of the viewprovider may be triggered by the clearselection of the UI command, this won't update the elements widget,
// in the accumulative of actions it is judged that it is worth to trigger an update here.
this->Geometry.setValues(std::move(newVals));
solverNeedsUpdate=true;
return 0;