From 5cbeef9b33dfd7e52ff2be250763309412e08001 Mon Sep 17 00:00:00 2001 From: wmayer Date: Fri, 18 Apr 2025 19:03:17 +0200 Subject: [PATCH] Gui: Fix TreeWidget::addDependentToSelection Avoid stack overflow for cyclic dependencies. This fixes issue 20859 --- src/Gui/Tree.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/Gui/Tree.cpp b/src/Gui/Tree.cpp index 3158d07c2f..9e00901b96 100644 --- a/src/Gui/Tree.cpp +++ b/src/Gui/Tree.cpp @@ -1305,9 +1305,11 @@ void TreeWidget::addDependentToSelection(App::Document* doc, App::DocumentObject Selection().addSelection(doc->getName(), docObject->getNameInDocument()); // get the dependent auto subObjectList = docObject->getOutList(); - // the dependent can in turn have dependents, thus add them recursively - for (auto itDepend = subObjectList.begin(); itDepend != subObjectList.end(); ++itDepend) - addDependentToSelection(doc, (*itDepend)); + for (auto itDepend : subObjectList) { + if (!Selection().isSelected(itDepend)) { + addDependentToSelection(doc, itDepend); + } + } } // add dependents of the selected tree object to selection