From 5d29f600409b67a7d865e1cdd0446eee64c8e068 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Benjamin=20Br=C3=A6strup=20Sayoc?= Date: Tue, 12 Jul 2022 17:54:25 +0200 Subject: [PATCH] [TechDraw] Improve readability of ViewProviderGeomHatch.cpp --- .../TechDraw/Gui/ViewProviderDimension.cpp | 23 ++++++++----------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/src/Mod/TechDraw/Gui/ViewProviderDimension.cpp b/src/Mod/TechDraw/Gui/ViewProviderDimension.cpp index ae509e00a8..a4adad8ee7 100644 --- a/src/Mod/TechDraw/Gui/ViewProviderDimension.cpp +++ b/src/Mod/TechDraw/Gui/ViewProviderDimension.cpp @@ -133,21 +133,18 @@ void ViewProviderDimension::setupContextMenu(QMenu* menu, QObject* receiver, con bool ViewProviderDimension::setEdit(int ModNum) { - if (ModNum == ViewProvider::Default) { - if (Gui::Control().activeDialog()) { // if TaskPanel already open - return false; - } - // clear the selection (convenience) - Gui::Selection().clearSelection(); - auto qgivDimension(dynamic_cast(getQView())); - if (qgivDimension) { - Gui::Control().showDialog(new TaskDlgDimension(qgivDimension, this)); - } - return true; - } - else { + if (ModNum != ViewProvider::Default) { return ViewProviderDrawingView::setEdit(ModNum); } + if (Gui::Control().activeDialog()) { // if TaskPanel already open + return false; + } + // clear the selection (convenience) + Gui::Selection().clearSelection(); + auto qgivDimension(dynamic_cast(getQView())); + if (qgivDimension) { + Gui::Control().showDialog(new TaskDlgDimension(qgivDimension, this)); + } return true; }