kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
This commit is contained in:
João Matos
2025-03-02 19:47:55 +00:00
committed by GitHub
parent 5d97c20cc7
commit 5e72c0afe5
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tools/lint/generic_checks.py
View File

@@ -35,11 +35,8 @@ def check_trailing_whitespace(file_paths):
for path in file_paths: for path in file_paths:
try: try:
with open(path, "r", encoding="utf-8") as f: with open(path, "r", encoding="utf-8") as f:
lines = f.readlines() lines = files.read().splitlines()
error_lines = [] error_lines = [idx if line.endswith(" ") for idx, line in enumerate(lines, start=1)]
for idx, line in enumerate(lines, start=1):
if line.rstrip("\n") != line.rstrip():
error_lines.append(idx)
if error_lines: if error_lines:
issues[path] = error_lines issues[path] = error_lines
except Exception as e: except Exception as e:
@@ -57,10 +54,7 @@ def check_tabs(file_paths):
try: try:
with open(path, "r", encoding="utf-8") as f: with open(path, "r", encoding="utf-8") as f:
lines = f.readlines() lines = f.readlines()
tab_lines = [] tab_lines = [idx if "\t" in line for idx, line in enumerate(lines, start=1)]
for idx, line in enumerate(lines, start=1):
if "\t" in line:
tab_lines.append(idx)
if tab_lines: if tab_lines:
issues[path] = tab_lines issues[path] = tab_lines
except Exception as e: except Exception as e: