From 5fa05ab83d8206a145e08becceee75f8f9214f61 Mon Sep 17 00:00:00 2001
From: berniev <bernievbb@icloud.com>
Date: Mon, 8 Aug 2022 23:54:39 +1000
Subject: [PATCH] Mod: Redundant_string_initialization

---
 src/Mod/Fem/App/FemMesh.cpp                  | 2 +-
 src/Mod/Part/App/TopoShape.cpp               | 2 +-
 src/Mod/PartDesign/App/ShapeBinder.cpp       | 2 +-
 src/Mod/PartDesign/Gui/ViewProvider.cpp      | 2 +-
 src/Mod/Sketcher/App/Constraint.cpp          | 1 -
 src/Mod/TechDraw/App/AppTechDrawPy.cpp       | 2 +-
 src/Mod/TechDraw/App/DrawViewSpreadsheet.cpp | 2 +-
 src/Mod/TechDraw/Gui/TaskSectionView.cpp     | 1 -
 src/Mod/TechDraw/Gui/ViewProviderPage.cpp    | 1 -
 9 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/src/Mod/Fem/App/FemMesh.cpp b/src/Mod/Fem/App/FemMesh.cpp
index bc00ca545f..6761f001b9 100644
--- a/src/Mod/Fem/App/FemMesh.cpp
+++ b/src/Mod/Fem/App/FemMesh.cpp
@@ -2157,7 +2157,7 @@ void FemMesh::writeABAQUS(const std::string &Filename, int elemParam, bool group
 
 
     // write volumes to file
-    std::string elsetname = "";
+    std::string elsetname;
     if (!elementsMapVol.empty()) {
         for (ElementsMap::iterator it = elementsMapVol.begin(); it != elementsMapVol.end(); ++it) {
             anABAQUS_Output << "** Volume elements" << std::endl;
diff --git a/src/Mod/Part/App/TopoShape.cpp b/src/Mod/Part/App/TopoShape.cpp
index e81defea55..770be905ad 100644
--- a/src/Mod/Part/App/TopoShape.cpp
+++ b/src/Mod/Part/App/TopoShape.cpp
@@ -511,7 +511,7 @@ const std::string &TopoShape::shapeName(TopAbs_ShapeEnum type, bool silent) {
         return _ShapeNames[type];
     if(!silent)
         FC_THROWM(Base::CADKernelError, "invalid shape type '" << type << "'");
-    static std::string ret("");
+    static std::string ret;
     return ret;
 }
 
diff --git a/src/Mod/PartDesign/App/ShapeBinder.cpp b/src/Mod/PartDesign/App/ShapeBinder.cpp
index 92c33afac4..33adbcaec6 100644
--- a/src/Mod/PartDesign/App/ShapeBinder.cpp
+++ b/src/Mod/PartDesign/App/ShapeBinder.cpp
@@ -618,7 +618,7 @@ void SubShapeBinder::update(SubShapeBinder::UpdateOption options) {
 
         const auto& subvals = copied ? _CopiedLink.getSubValues() : l.getSubValues();
         std::set<std::string> subs(subvals.begin(), subvals.end());
-        static std::string none("");
+        static std::string none;
         if (subs.empty())
             subs.insert(none);
         else if (subs.size() > 1)
diff --git a/src/Mod/PartDesign/Gui/ViewProvider.cpp b/src/Mod/PartDesign/Gui/ViewProvider.cpp
index b7ae0e3413..b896352488 100644
--- a/src/Mod/PartDesign/Gui/ViewProvider.cpp
+++ b/src/Mod/PartDesign/Gui/ViewProvider.cpp
@@ -50,7 +50,7 @@ using namespace PartDesignGui;
 PROPERTY_SOURCE_WITH_EXTENSIONS(PartDesignGui::ViewProvider, PartGui::ViewProviderPart)
 
 ViewProvider::ViewProvider()
-:oldWb(""), oldTip(nullptr), isSetTipIcon(false)
+: oldTip(nullptr), isSetTipIcon(false)
 {
     PartGui::ViewProviderAttachExtension::initExtension(this);
 }
diff --git a/src/Mod/Sketcher/App/Constraint.cpp b/src/Mod/Sketcher/App/Constraint.cpp
index 802dc7fe84..33094f54a7 100644
--- a/src/Mod/Sketcher/App/Constraint.cpp
+++ b/src/Mod/Sketcher/App/Constraint.cpp
@@ -47,7 +47,6 @@ Constraint::Constraint()
 : Value(0.0),
   Type(None),
   AlignmentType(Undef),
-  Name(""),
   First(GeoEnum::GeoUndef),
   FirstPos(PointPos::none),
   Second(GeoEnum::GeoUndef),
diff --git a/src/Mod/TechDraw/App/AppTechDrawPy.cpp b/src/Mod/TechDraw/App/AppTechDrawPy.cpp
index a74b8c8ecf..d218e9e283 100644
--- a/src/Mod/TechDraw/App/AppTechDrawPy.cpp
+++ b/src/Mod/TechDraw/App/AppTechDrawPy.cpp
@@ -1212,7 +1212,7 @@ private:
             throw Py::Exception();
 
         std::string svg(svgcode);
-        std::string empty = "";
+        std::string empty;
         std::string endline = "--endOfLine--";
         std::string linebreak = "\\n";
         // removing linebreaks for regex to work
diff --git a/src/Mod/TechDraw/App/DrawViewSpreadsheet.cpp b/src/Mod/TechDraw/App/DrawViewSpreadsheet.cpp
index 9efbf2b2fc..75323958ff 100644
--- a/src/Mod/TechDraw/App/DrawViewSpreadsheet.cpp
+++ b/src/Mod/TechDraw/App/DrawViewSpreadsheet.cpp
@@ -298,7 +298,7 @@ std::string DrawViewSpreadsheet::getSheetImage()
             int alignment = 0;
             std::string bcolor = "none";
             std::string fcolor = c.asHexString();
-            std::string textstyle = "";
+            std::string textstyle;
             if (cell) {
                 App::Color f,b;
                 std::set<std::string> st;
diff --git a/src/Mod/TechDraw/Gui/TaskSectionView.cpp b/src/Mod/TechDraw/Gui/TaskSectionView.cpp
index 2ae0a1588c..4c1b8ec3ab 100644
--- a/src/Mod/TechDraw/Gui/TaskSectionView.cpp
+++ b/src/Mod/TechDraw/Gui/TaskSectionView.cpp
@@ -76,7 +76,6 @@ TaskSectionView::TaskSectionView(TechDraw::DrawViewPart* base) :
     m_base(base),
     m_section(nullptr),
     m_saveScale(1.0),
-    m_dirName(""),
     m_doc(nullptr),
     m_createMode(true),
     m_saved(false),
diff --git a/src/Mod/TechDraw/Gui/ViewProviderPage.cpp b/src/Mod/TechDraw/Gui/ViewProviderPage.cpp
index b543179b4b..0f78c88b39 100644
--- a/src/Mod/TechDraw/Gui/ViewProviderPage.cpp
+++ b/src/Mod/TechDraw/Gui/ViewProviderPage.cpp
@@ -79,7 +79,6 @@ PROPERTY_SOURCE(TechDrawGui::ViewProviderPage, Gui::ViewProviderDocumentObject)
 ViewProviderPage::ViewProviderPage()
   : m_mdiView(nullptr),
     m_docReady(true),
-    m_pageName(""),
     m_graphicsView(nullptr),
     m_graphicsScene(nullptr)
 {