kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Fix regressions in CI linting generic checks.

Browse Source 
This got broken due to applying some review suggestions without proper
testing.

This fixes commit 5e72c0afe5.

Closes https://github.com/FreeCAD/FreeCAD/issues/21231.
This commit is contained in:
tritao
2025-05-09 23:50:05 +01:00
committed by Benjamin Nauck
parent 58fb7d45c1
commit 6517ebcdff
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tools/lint/generic_checks.py
View File

@@ -35,8 +35,12 @@ def check_trailing_whitespace(file_paths):
for path in file_paths:
try:
with open(path, "r", encoding="utf-8") as f:
lines = files.read().splitlines()
error_lines = [idx if line.endswith(" ") for idx, line in enumerate(lines, start=1)]
lines = f.read().splitlines()
error_lines = [
idx
for idx, line in enumerate(lines, start=1)
if line != line.rstrip()
]
if error_lines:
issues[path] = error_lines
except Exception as e:
@@ -53,8 +57,10 @@ def check_tabs(file_paths):
for path in file_paths:
try:
with open(path, "r", encoding="utf-8") as f:
lines = f.readlines()
tab_lines = [idx if "\t" in line for idx, line in enumerate(lines, start=1)]
lines = f.read().splitlines()
tab_lines = [
idx for idx, line in enumerate(lines, start=1) if "\t" in line
]
if tab_lines:
issues[path] = tab_lines
except Exception as e: