kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sketcher: Allow user to reset OVP state using backspace key

Browse Source 
Currently if user tries to reset OVP, they can only do that by entering
"0" for example, and then the parameters will get unset in
unsetOnViewParameter. But that will only happen if user types a value
that's under confusion point (typically 1e^-7). In my opinion, it would
be cool to reset that state if user deletes all content in the label, to
allow them to specify coordinates with mouse once again.

Also, this patch fixes a regression with backspace, where deleting stuff
from OVP was working on unix systems, but seems like on Windows it
doesn't pass the check.
This commit is contained in:
tetektoza
2025-06-07 21:00:27 +02:00
committed by Kacper Donat
parent e4b1512ae9
commit 6664907bd5
5 changed files with 29 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Mod/Sketcher/Gui/DrawSketchController.h
View File

@@ -618,6 +618,16 @@ protected:
parameter->setColor(colorManager.dimConstrColor);
onViewValueChanged(i, value);
});
// this gets triggered whenever user deletes content in OVP, we remove the
// constraints and unset everything to give user another change to select stuff
// with mouse
QObject::connect(parameter,
&Gui::EditableDatumLabel::parameterUnset,
[this, parameter]() {
unsetOnViewParameter(parameter);
finishControlsChanged();
});
}
}

7
src/Mod/Sketcher/Gui/DrawSketchKeyboardManager.cpp
View File

@@ -101,8 +101,11 @@ void DrawSketchKeyboardManager::detectKeyboardEventHandlingMode(QKeyEvent* keyEv
if (keyEvent->key() == Qt::Key_Enter || keyEvent->key() == Qt::Key_Return
|| keyEvent->key() == Qt::Key_Tab || keyEvent->key() == Qt::Key_Backtab
|| keyEvent->key() == Qt::Key_Minus || keyEvent->key() == Qt::Key_Period
|| keyEvent->key() == Qt::Key_Comma || match.hasMatch()
|| keyEvent->matches(QKeySequence::Backspace) || keyEvent->matches(QKeySequence::Delete)) {
|| keyEvent->key() == Qt::Key_Comma
|| match.hasMatch()
// double check for backspace as there may be windows/unix inconsistencies
|| keyEvent->key() == Qt::Key_Backspace || keyEvent->matches(QKeySequence::Backspace)
|| keyEvent->matches(QKeySequence::Delete)) {
keyMode = KeyboardEventHandlingMode::DSHControl;
timer.start(timeOutValue);
}