kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[TD]clazy warning re 3 parameter QObject::connect

Browse Source
This commit is contained in:
wandererfan
2022-08-23 13:50:26 -04:00
committed by WandererFan
parent dfafe7e04a
commit 67ce559bc5
3 changed files with 20 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/TechDraw/App/DrawViewDetail.cpp
View File

@@ -216,9 +216,11 @@ void DrawViewDetail::detailExec(TopoDS_Shape& shape,
return;
}
connectDetailWatcher = QObject::connect(&m_detailWatcher, &QFutureWatcherBase::finished, [this] {
this->onMakeDetailFinished();
});
//note that &m_detailWatcher in the third parameter is not strictly required, but using the
//4 parameter signature instead of the 3 parameter signature prevents clazy warning:
//https://github.com/KDE/clazy/blob/1.11/docs/checks/README-connect-3arg-lambda.md
connectDetailWatcher = QObject::connect(&m_detailWatcher, &QFutureWatcherBase::finished,
&m_detailWatcher, [this] { this->onMakeDetailFinished(); });
m_detailFuture = QtConcurrent::run(this, &DrawViewDetail::makeDetailShape, shape, dvp, dvs);
m_detailWatcher.setFuture(m_detailFuture);
waitingForDetail(true);