From 6930e0ac038d43281d1e19d2aa00771afd7b7120 Mon Sep 17 00:00:00 2001 From: Joao Matos Date: Sat, 14 Jun 2025 11:38:54 +0100 Subject: [PATCH] FastSignals: Normalize namespace to `fastsignals`. --- src/3rdParty/FastSignals/docs/bind_weak.md | 10 +++++----- .../FastSignals/docs/migration-from-boost-signals2.md | 6 +++--- src/3rdParty/FastSignals/docs/simple-examples.md | 4 ++-- .../libfastsignals/include/fastsignals/bind_weak.h | 4 ++-- .../libfastsignals/include/fastsignals/combiners.h | 4 ++-- .../libfastsignals/include/fastsignals/connection.h | 4 ++-- .../libfastsignals/include/fastsignals/function.h | 4 ++-- .../include/fastsignals/function_detail.h | 4 ++-- .../libfastsignals/include/fastsignals/signal.h | 8 ++++---- .../libfastsignals/include/fastsignals/signal_impl.h | 4 ++-- .../libfastsignals/include/fastsignals/spin_mutex.h | 4 ++-- .../libfastsignals/include/fastsignals/type_traits.h | 4 ++-- .../FastSignals/libfastsignals/src/connection.cpp | 4 ++-- .../FastSignals/libfastsignals/src/function_detail.cpp | 4 ++-- .../FastSignals/libfastsignals/src/signal_impl.cpp | 4 ++-- .../signal_stress_tests.cpp | 2 +- .../tests/libfastsignals_unit_tests/Function_tests.cpp | 2 +- .../libfastsignals_unit_tests/bind_weak_tests.cpp | 2 +- .../tests/libfastsignals_unit_tests/signal_tests.cpp | 2 +- 19 files changed, 40 insertions(+), 40 deletions(-) diff --git a/src/3rdParty/FastSignals/docs/bind_weak.md b/src/3rdParty/FastSignals/docs/bind_weak.md index 297b051a71..338b3574a4 100644 --- a/src/3rdParty/FastSignals/docs/bind_weak.md +++ b/src/3rdParty/FastSignals/docs/bind_weak.md @@ -2,13 +2,13 @@ ## Usage -* Use `is::signals::bind_weak` instead of `std::bind` to ensure that nothing happens if method called when binded object already destroyed +* Use `fastsignals::bind_weak` instead of `std::bind` to ensure that nothing happens if method called when binded object already destroyed * Pass pointer to T class method as first argument, `shared_ptr` or `weak_ptr` as second argument * Example: `bind_weak(&Document::save(), document, std::placeholders::_1)`, where `document` is a `weak_ptr` or `shared_ptr` ## Weak this idiom -The `is::signals::bind_weak(...)` function implements "weak this" idiom. This idiom helps to avoid dangling pointers and memory access wiolations in asynchronous and/or multithreaded programs. +The `fastsignals::bind_weak(...)` function implements "weak this" idiom. This idiom helps to avoid dangling pointers and memory access wiolations in asynchronous and/or multithreaded programs. In the following example, we use weak this idiom to avoid using dangling pointer wehn calling `print()` method of the `Enityt`: @@ -58,7 +58,7 @@ In the following example, `Entity::print()` method connected to the signal. Sign #include #include -using VoidSignal = is::signals::signal; +using VoidSignal = fastsignals::signal; using VoidSlot = VoidSignal::slot_type; struct Entity : std::enable_shared_from_this @@ -67,8 +67,8 @@ struct Entity : std::enable_shared_from_this VoidSlot get_print_slot() { - // Here is::signals::bind_weak() used instead of std::bind. - return is::signals::bind_weak(&Entity::print, weak_from_this()); + // Here fastsignals::bind_weak() used instead of std::bind. + return fastsignals::bind_weak(&Entity::print, weak_from_this()); } void print() diff --git a/src/3rdParty/FastSignals/docs/migration-from-boost-signals2.md b/src/3rdParty/FastSignals/docs/migration-from-boost-signals2.md index 27116e89bd..72632caf74 100644 --- a/src/3rdParty/FastSignals/docs/migration-from-boost-signals2.md +++ b/src/3rdParty/FastSignals/docs/migration-from-boost-signals2.md @@ -120,7 +120,7 @@ FastSignals uses another approach: `bind_weak` function: #include #include -using VoidSignal = is::signals::signal; +using VoidSignal = fastsignals::signal; using VoidSlot = VoidSignal::slot_type; struct Entity : std::enable_shared_from_this @@ -129,8 +129,8 @@ struct Entity : std::enable_shared_from_this VoidSlot get_print_slot() { - // Here is::signals::bind_weak() used instead of std::bind. - return is::signals::bind_weak(&Entity::print, weak_from_this()); + // Here fastsignals::bind_weak() used instead of std::bind. + return fastsignals::bind_weak(&Entity::print, weak_from_this()); } void print() diff --git a/src/3rdParty/FastSignals/docs/simple-examples.md b/src/3rdParty/FastSignals/docs/simple-examples.md index 05b112aa28..3f067b347f 100644 --- a/src/3rdParty/FastSignals/docs/simple-examples.md +++ b/src/3rdParty/FastSignals/docs/simple-examples.md @@ -11,7 +11,7 @@ // 17 #include "libfastsignals/signal.h" -using namespace is::signals; +using namespace fastsignals; int main() { @@ -37,7 +37,7 @@ int main() // 17 #include "libfastsignals/signal.h" -using namespace is::signals; +using namespace fastsignals; int main() { diff --git a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/bind_weak.h b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/bind_weak.h index 9a60c7d1a7..bd95b0eca7 100644 --- a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/bind_weak.h +++ b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/bind_weak.h @@ -1,6 +1,6 @@ #pragma once -namespace is::signals +namespace fastsignals { namespace detail { @@ -72,4 +72,4 @@ decltype(auto) bind_weak(ReturnType (ClassType::*memberFn)(Params... args) const return std::bind(invoker, args...); } -} // namespace is::signals +} // namespace fastsignals diff --git a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/combiners.h b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/combiners.h index d3254b5598..3b83c42c0d 100644 --- a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/combiners.h +++ b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/combiners.h @@ -2,7 +2,7 @@ #include -namespace is::signals +namespace fastsignals { /** @@ -37,4 +37,4 @@ public: using result_type = void; }; -} // namespace is::signals +} // namespace fastsignals diff --git a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/connection.h b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/connection.h index 08b661ce46..33357c3bf6 100644 --- a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/connection.h +++ b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/connection.h @@ -2,7 +2,7 @@ #include "signal_impl.h" -namespace is::signals +namespace fastsignals { // Connection keeps link between signal and slot and can disconnect them. @@ -111,4 +111,4 @@ public: advanced_connection release() noexcept; }; -} // namespace is::signals +} // namespace fastsignals diff --git a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/function.h b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/function.h index 07282cfd5e..a4fcabb3ed 100644 --- a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/function.h +++ b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/function.h @@ -2,7 +2,7 @@ #include "function_detail.h" -namespace is::signals +namespace fastsignals { // Derive your class from not_directly_callable to prevent function from wrapping it using its template constructor // Useful if your class provides custom operator for casting to function @@ -51,4 +51,4 @@ private: detail::packed_function m_packed; }; -} // namespace is::signals +} // namespace fastsignals diff --git a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/function_detail.h b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/function_detail.h index 033f607a4b..c3d09eae0e 100644 --- a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/function_detail.h +++ b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/function_detail.h @@ -6,7 +6,7 @@ #include #include -namespace is::signals::detail +namespace fastsignals::detail { /// Buffer for callable object in-place construction, /// helps to implement Small Buffer Optimization. @@ -161,4 +161,4 @@ private: base_function_proxy* m_proxy = nullptr; }; -} // namespace is::signals::detail +} // namespace fastsignals::detail diff --git a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/signal.h b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/signal.h index 43333bb2d2..15fc114521 100644 --- a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/signal.h +++ b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/signal.h @@ -11,7 +11,7 @@ # include "msvc_autolink.h" #endif -namespace is::signals +namespace fastsignals { template class Combiner = optional_last_value> class signal; @@ -136,7 +136,7 @@ private: detail::signal_impl_ptr m_slots; }; -} // namespace is::signals +} // namespace fastsignals namespace std { @@ -144,8 +144,8 @@ namespace std // free swap function, findable by ADL template class Combiner> void swap( - ::is::signals::signal& sig1, - ::is::signals::signal& sig2) + ::fastsignals::signal& sig1, + ::fastsignals::signal& sig2) { sig1.swap(sig2); } diff --git a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/signal_impl.h b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/signal_impl.h index 13572a5a82..e5042e1875 100644 --- a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/signal_impl.h +++ b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/signal_impl.h @@ -5,7 +5,7 @@ #include #include -namespace is::signals::detail +namespace fastsignals::detail { class signal_impl @@ -56,4 +56,4 @@ private: using signal_impl_ptr = std::shared_ptr; using signal_impl_weak_ptr = std::weak_ptr; -} // namespace is::signals::detail +} // namespace fastsignals::detail diff --git a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/spin_mutex.h b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/spin_mutex.h index 2d7755c5b1..b8e4229cdb 100644 --- a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/spin_mutex.h +++ b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/spin_mutex.h @@ -1,7 +1,7 @@ #pragma once #include -namespace is::signals::detail +namespace fastsignals::detail { class spin_mutex @@ -35,4 +35,4 @@ private: std::atomic_flag m_busy = ATOMIC_FLAG_INIT; }; -} // namespace is::signals::detail +} // namespace fastsignals::detail diff --git a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/type_traits.h b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/type_traits.h index 0a18a5a86a..f0d6af11c4 100644 --- a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/type_traits.h +++ b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/type_traits.h @@ -1,6 +1,6 @@ #pragma once -namespace is::signals +namespace fastsignals { namespace detail { @@ -21,4 +21,4 @@ struct signal_arg template using signal_arg_t = typename detail::signal_arg::type; -} // namespace is::signals +} // namespace fastsignals diff --git a/src/3rdParty/FastSignals/libfastsignals/src/connection.cpp b/src/3rdParty/FastSignals/libfastsignals/src/connection.cpp index fbce73a321..9a71745a1b 100644 --- a/src/3rdParty/FastSignals/libfastsignals/src/connection.cpp +++ b/src/3rdParty/FastSignals/libfastsignals/src/connection.cpp @@ -1,6 +1,6 @@ #include "../include/fastsignals/connection.h" -namespace is::signals +namespace fastsignals { namespace { @@ -248,4 +248,4 @@ advanced_connection advanced_scoped_connection::release() noexcept return conn; } -} // namespace is::signals +} // namespace fastsignals diff --git a/src/3rdParty/FastSignals/libfastsignals/src/function_detail.cpp b/src/3rdParty/FastSignals/libfastsignals/src/function_detail.cpp index c5eada1a8c..c807e7c1d1 100644 --- a/src/3rdParty/FastSignals/libfastsignals/src/function_detail.cpp +++ b/src/3rdParty/FastSignals/libfastsignals/src/function_detail.cpp @@ -2,7 +2,7 @@ #include #include -namespace is::signals::detail +namespace fastsignals::detail { packed_function::packed_function(packed_function&& other) noexcept @@ -93,4 +93,4 @@ bool packed_function::is_buffer_allocated() const noexcept && std::less()(m_proxy, &m_buffer[1]); } -} // namespace is::signals::detail +} // namespace fastsignals::detail diff --git a/src/3rdParty/FastSignals/libfastsignals/src/signal_impl.cpp b/src/3rdParty/FastSignals/libfastsignals/src/signal_impl.cpp index ef8702ad4d..4c345f24d5 100644 --- a/src/3rdParty/FastSignals/libfastsignals/src/signal_impl.cpp +++ b/src/3rdParty/FastSignals/libfastsignals/src/signal_impl.cpp @@ -2,7 +2,7 @@ #include #include -namespace is::signals::detail +namespace fastsignals::detail { uint64_t signal_impl::add(packed_function fn) @@ -81,4 +81,4 @@ size_t signal_impl::count() const noexcept return m_functions.size(); } -} // namespace is::signals::detail +} // namespace fastsignals::detail diff --git a/src/3rdParty/FastSignals/tests/libfastsignals_stress_tests/signal_stress_tests.cpp b/src/3rdParty/FastSignals/tests/libfastsignals_stress_tests/signal_stress_tests.cpp index 52f7b993f0..04d880ec52 100644 --- a/src/3rdParty/FastSignals/tests/libfastsignals_stress_tests/signal_stress_tests.cpp +++ b/src/3rdParty/FastSignals/tests/libfastsignals_stress_tests/signal_stress_tests.cpp @@ -5,7 +5,7 @@ #include #include -using namespace is::signals; +using namespace fastsignals; namespace { diff --git a/src/3rdParty/FastSignals/tests/libfastsignals_unit_tests/Function_tests.cpp b/src/3rdParty/FastSignals/tests/libfastsignals_unit_tests/Function_tests.cpp index 3ca5dc7a6f..ddf0894b56 100644 --- a/src/3rdParty/FastSignals/tests/libfastsignals_unit_tests/Function_tests.cpp +++ b/src/3rdParty/FastSignals/tests/libfastsignals_unit_tests/Function_tests.cpp @@ -2,7 +2,7 @@ #include #include -using namespace is::signals; +using namespace fastsignals; namespace { diff --git a/src/3rdParty/FastSignals/tests/libfastsignals_unit_tests/bind_weak_tests.cpp b/src/3rdParty/FastSignals/tests/libfastsignals_unit_tests/bind_weak_tests.cpp index b9f1f2e01e..88a34cf61c 100644 --- a/src/3rdParty/FastSignals/tests/libfastsignals_unit_tests/bind_weak_tests.cpp +++ b/src/3rdParty/FastSignals/tests/libfastsignals_unit_tests/bind_weak_tests.cpp @@ -1,7 +1,7 @@ #include "catch2/catch.hpp" #include -using namespace is::signals; +using namespace fastsignals; namespace { diff --git a/src/3rdParty/FastSignals/tests/libfastsignals_unit_tests/signal_tests.cpp b/src/3rdParty/FastSignals/tests/libfastsignals_unit_tests/signal_tests.cpp index 1d58ee3956..b31c6f646e 100644 --- a/src/3rdParty/FastSignals/tests/libfastsignals_unit_tests/signal_tests.cpp +++ b/src/3rdParty/FastSignals/tests/libfastsignals_unit_tests/signal_tests.cpp @@ -2,7 +2,7 @@ #include #include -using namespace is::signals; +using namespace fastsignals; using namespace std::literals; namespace