From 6a877f7e292dcc9f795b261aa37837d1a652f5ed Mon Sep 17 00:00:00 2001
From: Uwe <donovaly@users.noreply.github.com>
Date: Sun, 12 Jun 2022 00:25:58 +0200
Subject: [PATCH] [FEM] point filter: fix initialization issue

- we cannot assume to have a geometry at position (0, 0, 1) this initialize at (0, 0, 0)
- also don't hardcode the unit in the UI file

- also fix wrong property description
- property "Radius" is not used in the code and it seems it is only there as copy paste bug once the point filter was implemented. However close to a release, keep the property and just mention it is unused.
---
 src/Mod/Fem/App/FemPostFilter.cpp      | 6 +++---
 src/Mod/Fem/Gui/TaskPostDataAtPoint.ui | 9 ---------
 2 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/src/Mod/Fem/App/FemPostFilter.cpp b/src/Mod/Fem/App/FemPostFilter.cpp
index 20bfef00d0..aeba7649fb 100644
--- a/src/Mod/Fem/App/FemPostFilter.cpp
+++ b/src/Mod/Fem/App/FemPostFilter.cpp
@@ -335,11 +335,11 @@ PROPERTY_SOURCE(Fem::FemPostDataAtPointFilter, Fem::FemPostFilter)
 
 FemPostDataAtPointFilter::FemPostDataAtPointFilter(void) : FemPostFilter() {
 
-    ADD_PROPERTY_TYPE(Center, (Base::Vector3d(0.0, 0.0, 1.0)), "DataAtPoint", App::Prop_None, "The center used to define the center of the point");
-    ADD_PROPERTY_TYPE(Radius, (0), "DataAtPoint", App::Prop_None, "The point 2 used to define end point of line");
+    ADD_PROPERTY_TYPE(Center, (Base::Vector3d(0.0, 0.0, 0.0)), "DataAtPoint", App::Prop_None, "Center of the point");
+    ADD_PROPERTY_TYPE(Radius, (0), "DataAtPoint", App::Prop_None, "Radius around the point (unused)");
     ADD_PROPERTY_TYPE(PointData, (0), "DataAtPoint", App::Prop_None, "Point data values used for plotting");
     ADD_PROPERTY_TYPE(FieldName, (""), "DataAtPoint", App::Prop_None, "Field used for plotting");
-    ADD_PROPERTY_TYPE(Unit, (""), "DataAtPoint", App::Prop_None, "Unit used for Field");
+    ADD_PROPERTY_TYPE(Unit, (""), "DataAtPoint", App::Prop_None, "Unit used for the field");
 
     PointData.setStatus(App::Property::Output, true);
     FieldName.setStatus(App::Property::ReadOnly, true);
diff --git a/src/Mod/Fem/Gui/TaskPostDataAtPoint.ui b/src/Mod/Fem/Gui/TaskPostDataAtPoint.ui
index 738652ce1a..0d40ef62e5 100644
--- a/src/Mod/Fem/Gui/TaskPostDataAtPoint.ui
+++ b/src/Mod/Fem/Gui/TaskPostDataAtPoint.ui
@@ -61,9 +61,6 @@
         <property name="keyboardTracking">
          <bool>false</bool>
         </property>
-        <property name="unit" stdset="0">
-         <string notr="true">mm</string>
-        </property>
        </widget>
       </item>
       <item row="2" column="1">
@@ -80,9 +77,6 @@
         <property name="keyboardTracking">
          <bool>false</bool>
         </property>
-        <property name="unit" stdset="0">
-         <string notr="true">mm</string>
-        </property>
        </widget>
       </item>
       <item row="2" column="2">
@@ -99,9 +93,6 @@
         <property name="keyboardTracking">
          <bool>false</bool>
         </property>
-        <property name="unit" stdset="0">
-         <string notr="true">mm</string>
-        </property>
        </widget>
       </item>
      </layout>