From 6d81096b5af84a5d2775d01ab942d84f75bb0ad9 Mon Sep 17 00:00:00 2001 From: Andrea Date: Sun, 18 May 2025 17:32:17 +0200 Subject: [PATCH] SpreadSheet: remove function Observer is no longer required as PropertySheet is now derived from PropertyLinkBase and will handle all the link related behavior --- src/Mod/Spreadsheet/App/PropertySheet.cpp | 3 --- src/Mod/Spreadsheet/App/Sheet.cpp | 27 ----------------------- src/Mod/Spreadsheet/App/Sheet.h | 2 -- 3 files changed, 32 deletions(-) diff --git a/src/Mod/Spreadsheet/App/PropertySheet.cpp b/src/Mod/Spreadsheet/App/PropertySheet.cpp index 6e7f6538ea..389a8802f2 100644 --- a/src/Mod/Spreadsheet/App/PropertySheet.cpp +++ b/src/Mod/Spreadsheet/App/PropertySheet.cpp @@ -1372,8 +1372,6 @@ void PropertySheet::addDependencies(CellAddress key) std::string docObjName = docObj->getFullName(); - owner->observeDocument(doc); - documentObjectToCellMap[docObjName].insert(key); cellToDocumentObjectMap[key].insert(docObjName); ++updateCount; @@ -1447,7 +1445,6 @@ void PropertySheet::removeDependencies(CellAddress key) std::map>::iterator k = documentObjectToCellMap.find(*j); - // assert(k != documentObjectToCellMap.end()); if (k != documentObjectToCellMap.end()) { k->second.erase(key); diff --git a/src/Mod/Spreadsheet/App/Sheet.cpp b/src/Mod/Spreadsheet/App/Sheet.cpp index cacbe011fa..e2253da0cd 100644 --- a/src/Mod/Spreadsheet/App/Sheet.cpp +++ b/src/Mod/Spreadsheet/App/Sheet.cpp @@ -1661,33 +1661,6 @@ void Sheet::onDocumentRestored() } } -/** - * @brief Create a document observer for this sheet. Used to track changes. - * @param document document to observer. - */ - -void Sheet::observeDocument(Document* document) -{ - // observer is no longer required as PropertySheet is now derived from - // PropertyLinkBase and will handle all the link related behavior -#if 1 - (void)document; -#else - ObserverMap::const_iterator it = observers.find(document->getName()); - - if (it != observers.end()) { - // An observer already exists, increase reference counter for it - it->second->ref(); - } - else { - // Create a new observer - SheetObserver* observer = new SheetObserver(document, &cells); - - observers[document->getName()] = observer; - } -#endif -} - void Sheet::renameObjectIdentifiers(const std::map& paths) { DocumentObject::renameObjectIdentifiers(paths); diff --git a/src/Mod/Spreadsheet/App/Sheet.h b/src/Mod/Spreadsheet/App/Sheet.h index a2b6d7ad3a..d189ec9ec6 100644 --- a/src/Mod/Spreadsheet/App/Sheet.h +++ b/src/Mod/Spreadsheet/App/Sheet.h @@ -232,8 +232,6 @@ public: boost::signals2::signal rowHeightChanged; - void observeDocument(App::Document* document); - void renameObjectIdentifiers( const std::map& paths) override;