Fix several clazy issues:

* C++11 range-loop might detach Qt container [-Wclazy-range-loop-detach]
This commit is contained in:
wmayer
2022-07-24 23:48:37 +02:00
parent 0bef4e82f2
commit 6ee2c7f865
17 changed files with 63 additions and 36 deletions

View File

@@ -301,14 +301,16 @@ qint64 ApplicationCache::dirSize(QString dirPath) const
QDir dir(dirPath);
QDir::Filters fileFilters = QDir::Files;
for (QString filePath : dir.entryList(fileFilters)) {
const auto& files = dir.entryList(fileFilters);
for (const QString& filePath : files) {
QFileInfo fi(dir, filePath);
total += fi.size();
}
// traverse sub-directories recursively
QDir::Filters dirFilters = QDir::Dirs | QDir::NoDotAndDotDot;
for (QString subDirPath : dir.entryList(dirFilters))
const auto& dirs = dir.entryList(dirFilters);
for (const QString& subDirPath : dirs)
total += dirSize(dirPath + QDir::separator() + subDirPath);
return total;
}