kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's

Browse Source 
Regex based changes, manually verified
This commit is contained in:
Benjamin Nauck
2025-01-16 21:27:50 +01:00
parent 6a3eb2ab49
commit 6f535f19fb
166 changed files with 484 additions and 497 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/App/Expression.cpp
View File

@@ -2016,7 +2016,7 @@ Py::Object FunctionExpression::evalAggregate(
}
for (auto &arg : args) {
if (arg->isDerivedFrom(RangeExpression::getClassTypeId())) {
if (arg->isDerivedFrom<RangeExpression>()) {
Range range(static_cast<const RangeExpression&>(*arg).getRange());
do {
@@ -2159,7 +2159,7 @@ Py::Object FunctionExpression::evaluate(const Expression *expr, int f, const std
switch (f) {
case LIST: {
if (args.size() == 1 && args[0]->isDerivedFrom(RangeExpression::getClassTypeId()))
if (args.size() == 1 && args[0]->isDerivedFrom<RangeExpression>())
return args[0]->getPyValue();
Py::List list(args.size());
int i = 0;
@@ -2168,7 +2168,7 @@ Py::Object FunctionExpression::evaluate(const Expression *expr, int f, const std
return list;
}
case TUPLE: {
if (args.size() == 1 && args[0]->isDerivedFrom(RangeExpression::getClassTypeId()))
if (args.size() == 1 && args[0]->isDerivedFrom<RangeExpression>())
return Py::Tuple(args[0]->getPyValue());
Py::Tuple tuple(args.size());
int i = 0;