kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's

Browse Source 
Regex based changes, manually verified
This commit is contained in:
Benjamin Nauck
2025-01-16 21:27:50 +01:00
parent 6a3eb2ab49
commit 6f535f19fb
166 changed files with 484 additions and 497 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Gui/propertyeditor/PropertyEditor.cpp
View File

@@ -643,7 +643,7 @@ void PropertyEditor::buildUp(PropertyModel::PropertyList&& props, bool _checkDoc
continue;
}
// Include document to get proper handling in PropertyView::slotDeleteDocument()
if (checkDocument && container->isDerivedFrom(App::DocumentObject::getClassTypeId())) {
if (checkDocument && container->isDerivedFrom<App::DocumentObject>()) {
propOwners.insert(static_cast<App::DocumentObject*>(container)->getDocument());
}
propOwners.insert(container);
@@ -779,7 +779,7 @@ void PropertyEditor::contextMenuEvent(QContextMenuEvent*)
if (props.size() == 1) {
auto item = static_cast<PropertyItem*>(contextIndex.internalPointer());
auto prop = *props.begin();
if (item->isBound() && !prop->isDerivedFrom(App::PropertyExpressionEngine::getClassTypeId())
if (item->isBound() && !prop->isDerivedFrom<App::PropertyExpressionEngine>()
&& !prop->isReadOnly() && !prop->testStatus(App::Property::Immutable)
&& !(prop->getType() & App::Prop_ReadOnly)) {
contextIndex = propertyModel->buddy(contextIndex);