kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's

Browse Source 
Regex based changes, manually verified
This commit is contained in:
Benjamin Nauck
2025-01-16 21:27:50 +01:00
parent 6a3eb2ab49
commit 6f535f19fb
166 changed files with 484 additions and 497 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/Sketcher/Gui/DrawSketchHandler.cpp
View File

@@ -194,16 +194,14 @@ std::vector<Base::Vector2d> CurveConverter::toVector2D(const Part::Geometry* geo
{
std::vector<Base::Vector2d> vector2d;
const auto type = geometry->getTypeId();
auto emplaceasvector2d = [&vector2d](const Base::Vector3d& point) {
vector2d.emplace_back(point.x, point.y);
};
auto isconic = type.isDerivedFrom(Part::GeomConic::getClassTypeId());
auto isbounded = type.isDerivedFrom(Part::GeomBoundedCurve::getClassTypeId());
auto isconic = geometry->isDerivedFrom<Part::GeomConic>();
auto isbounded = geometry->isDerivedFrom<Part::GeomBoundedCurve>();
if (type == Part::GeomLineSegment::getClassTypeId()) { // add a line
if (geometry->is<Part::GeomLineSegment>()) { // add a line
auto geo = static_cast<const Part::GeomLineSegment*>(geometry);
emplaceasvector2d(geo->getStartPoint());