kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's

Browse Source 
Regex based changes, manually verified
This commit is contained in:
Benjamin Nauck
2025-01-16 21:27:50 +01:00
parent 6a3eb2ab49
commit 6f535f19fb
166 changed files with 484 additions and 497 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/TechDraw/App/DimensionReferences.cpp
View File

@@ -108,7 +108,7 @@ TopoDS_Shape ReferenceEntry::getGeometry() const
return {};
}
if ( getObject()->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId()) ) {
if ( getObject()->isDerivedFrom<TechDraw::DrawViewPart>() ) {
// 2d geometry from DrawViewPart will be rotated and scaled
return getGeometry2d();
}
@@ -277,14 +277,14 @@ bool ReferenceEntry::isWholeObject() const
bool ReferenceEntry::is3d() const
{
if (getObject() &&
getObject()->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId()) &&
getObject()->isDerivedFrom<TechDraw::DrawViewPart>() &&
!getSubName().empty()) {
// this is a well formed 2d reference
return false;
}
if (getObject() &&
getObject()->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId()) &&
getObject()->isDerivedFrom<TechDraw::DrawViewPart>() &&
getSubName().empty()) {
// this is a broken 3d reference, so it should be treated as 3d
return true;
@@ -302,7 +302,7 @@ bool ReferenceEntry::hasGeometry() const
return false;
}
if ( getObject()->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId()) ) {
if ( getObject()->isDerivedFrom<TechDraw::DrawViewPart>() ) {
// 2d reference
return hasGeometry2d();
}