kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's

Browse Source 
Regex based changes, manually verified
This commit is contained in:
Benjamin Nauck
2025-01-16 21:27:50 +01:00
parent 6a3eb2ab49
commit 6f535f19fb
166 changed files with 484 additions and 497 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/TechDraw/Gui/ViewProviderPageExtension.cpp
View File

@@ -61,7 +61,7 @@ bool ViewProviderPageExtension::extensionCanDropObjects() const { return true; }
bool ViewProviderPageExtension::extensionCanDropObject(App::DocumentObject* obj) const
{
// Accept links to views as well.
if (obj->isDerivedFrom(App::Link::getClassTypeId())) {
if (obj->isDerivedFrom<App::Link>()) {
auto* link = static_cast<App::Link*>(obj);
obj = link->getLinkedObject();
}
@@ -107,14 +107,14 @@ bool ViewProviderPageExtension::extensionCanDropObjectEx(App::DocumentObject* ob
void ViewProviderPageExtension::extensionDropObject(App::DocumentObject* obj)
{
bool linkToView = false;
if (obj->isDerivedFrom(App::Link::getClassTypeId())) {
if (obj->isDerivedFrom<App::Link>()) {
auto* link = static_cast<App::Link*>(obj);
if (link->getLinkedObject()->isDerivedFrom(TechDraw::DrawView::getClassTypeId())) {
if (link->getLinkedObject()->isDerivedFrom<TechDraw::DrawView>()) {
linkToView = true;
}
}
if (obj->isDerivedFrom(TechDraw::DrawView::getClassTypeId()) || linkToView) {
if (obj->isDerivedFrom<TechDraw::DrawView>() || linkToView) {
dropObject(obj);
return;
}