From 74c52c9063ec26bf8316ad8bc57a1a7dad524acd Mon Sep 17 00:00:00 2001 From: Florian Foinant-Willig Date: Tue, 13 Feb 2024 21:41:25 +0100 Subject: [PATCH] PD: handle null pointer in Feature::getBaseShape (#12385) --- src/Mod/PartDesign/App/Feature.cpp | 3 +++ tests/src/Base/Vector3D.cpp | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Mod/PartDesign/App/Feature.cpp b/src/Mod/PartDesign/App/Feature.cpp index 188607140a..63cc6e85ba 100644 --- a/src/Mod/PartDesign/App/Feature.cpp +++ b/src/Mod/PartDesign/App/Feature.cpp @@ -156,6 +156,9 @@ Part::Feature* Feature::getBaseObject(bool silent) const { const TopoDS_Shape& Feature::getBaseShape() const { const Part::Feature* BaseObject = getBaseObject(); + if (!BaseObject) + throw Base::ValueError("Base feature's shape is not defined"); + if (BaseObject->isDerivedFrom(PartDesign::ShapeBinder::getClassTypeId())|| BaseObject->isDerivedFrom(PartDesign::SubShapeBinder::getClassTypeId())) { diff --git a/tests/src/Base/Vector3D.cpp b/tests/src/Base/Vector3D.cpp index 6020637100..6dba2b5824 100644 --- a/tests/src/Base/Vector3D.cpp +++ b/tests/src/Base/Vector3D.cpp @@ -328,4 +328,3 @@ TEST(Vector, TestAngleOriented) } // NOLINTEND -