kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: Use auto and range-based for (#7481)

Browse Source 
* On lines where the variable type is obvious from inspection, avoid repeating the type using auto. 
* When possible use a ranged for loop instead of begin() and end() iterators
This commit is contained in:
berniev
2022-09-15 04:25:13 +10:00
committed by GitHub
parent d7792826b4
commit 75acacd1b7
175 changed files with 2051 additions and 2057 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Gui/SoNavigationDragger.cpp
View File

@@ -139,12 +139,12 @@ RotTransDragger::RotTransDragger()
// By calling 'setAnyPartAsDefault' instead of 'setAnyPart'
// we ensure that they will not be written out, unless
// they are changed later on.
SoRotation *XRot = new SoRotation;
auto XRot = new SoRotation;
XRot->rotation.setValue(
SbRotation(SbVec3f(0,1,0), SbVec3f(1,0,0)));
setAnyPartAsDefault("XRotatorRot", XRot);
SoRotation *ZRot = new SoRotation;
auto ZRot = new SoRotation;
ZRot->rotation.setValue(
SbRotation(SbVec3f(0,1,0), SbVec3f(0,0,1)));
setAnyPartAsDefault("ZRotatorRot", ZRot);
@@ -331,7 +331,7 @@ RotTransDragger::setUpConnections(SbBool onOff, SbBool doItAlways)
void
RotTransDragger::valueChangedCB(void *, SoDragger *inDragger)
{
RotTransDragger *myself = (RotTransDragger *) inDragger;
auto myself = (RotTransDragger *) inDragger;
// Factor the motionMatrix into its parts
SbMatrix motMat = myself->getMotionMatrix(); // clazy:exclude=rule-of-two-soft
@@ -355,7 +355,7 @@ RotTransDragger::valueChangedCB(void *, SoDragger *inDragger)
void
RotTransDragger::fieldSensorCB(void *inDragger, SoSensor *)
{
RotTransDragger *myself = (RotTransDragger *) inDragger;
auto myself = (RotTransDragger *) inDragger;
SbMatrix motMat = myself->getMotionMatrix(); // clazy:exclude=rule-of-two-soft
myself->workFieldsIntoTransform(motMat);
@@ -369,7 +369,7 @@ RotTransDragger::fieldSensorCB(void *inDragger, SoSensor *)
void
RotTransDragger::invalidateSurroundScaleCB(void *parent, SoDragger *)
{
RotTransDragger *myParentDragger = (RotTransDragger *) parent;
auto myParentDragger = (RotTransDragger *) parent;
// Invalidate the surroundScale, if it exists.
SoSurroundScale *mySS = SO_CHECK_PART(