kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: Use auto and range-based for (#7481)

Browse Source 
* On lines where the variable type is obvious from inspection, avoid repeating the type using auto. 
* When possible use a ranged for loop instead of begin() and end() iterators
This commit is contained in:
berniev
2022-09-15 04:25:13 +10:00
committed by GitHub
parent d7792826b4
commit 75acacd1b7
175 changed files with 2051 additions and 2057 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/Gui/TaskView/TaskSelectLinkProperty.cpp
View File

@@ -129,10 +129,10 @@ void TaskSelectLinkProperty::activate()
else if (LinkList) {
// save the start values for a cnacel operation (reject())
const std::vector<App::DocumentObject*> &Values = LinkList->getValues();
for(std::vector<App::DocumentObject*>::const_iterator it = Values.begin();it!=Values.end();++it)
for(const auto & Value : Values)
{
std::string ObjName = (*it)->getNameInDocument();
std::string DocName = (*it)->getDocument()->getName();
std::string ObjName = Value->getNameInDocument();
std::string DocName = Value->getDocument()->getName();
Gui::Selection().addSelection(DocName.c_str(),ObjName.c_str());
}
}
@@ -174,8 +174,8 @@ void TaskSelectLinkProperty::sendSelection2Property()
else if (LinkList) {
std::vector<Gui::SelectionObject> sel = Gui::Selection().getSelectionEx();
std::vector<App::DocumentObject*> temp;
for (std::vector<Gui::SelectionObject>::iterator it=sel.begin();it!=sel.end();++it)
temp.push_back(it->getObject());
for (auto & it : sel)
temp.push_back(it.getObject());
LinkList->setValues(temp);
}
@@ -208,12 +208,12 @@ void TaskSelectLinkProperty::OnChange(Gui::SelectionSingleton::SubjectType &rCal
Reason.Type == SelectionChanges::ClrSelection) {
ui->listWidget->clear();
std::vector<Gui::SelectionSingleton::SelObj> sel = Gui::Selection().getSelection();
for (std::vector<Gui::SelectionSingleton::SelObj>::const_iterator it=sel.begin();it!=sel.end();++it){
for (const auto & it : sel){
std::string temp;
temp += it->FeatName;
if (strcmp(it->SubName, "") != 0){
temp += it.FeatName;
if (strcmp(it.SubName, "") != 0){
temp += "::";
temp += it->SubName;
temp += it.SubName;
}
new QListWidgetItem(QString::fromLatin1(temp.c_str()), ui->listWidget);
}