From 768993c844956163b90c8e4f2746f7960db5fec1 Mon Sep 17 00:00:00 2001 From: jrheinlaender Date: Mon, 22 Oct 2012 16:25:24 +0200 Subject: [PATCH] PartDesign: minor comment improvements --- src/Mod/PartDesign/App/FeatureTransformed.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/Mod/PartDesign/App/FeatureTransformed.cpp b/src/Mod/PartDesign/App/FeatureTransformed.cpp index 574974a7a7..bf005ac003 100644 --- a/src/Mod/PartDesign/App/FeatureTransformed.cpp +++ b/src/Mod/PartDesign/App/FeatureTransformed.cpp @@ -138,7 +138,7 @@ App::DocumentObjectExecReturn *Transformed::execute(void) BRep_Builder builder; TopoDS_Compound transformedShapes; builder.MakeCompound(transformedShapes); - std::vector v_transformedShapes; // collect all the transformed shapes for history building + std::vector v_transformedShapes; // collect all the transformed shapes for intersection testing std::list::const_iterator t = transformations.begin(); t++; // Skip first transformation, which is always the identity transformation @@ -158,8 +158,7 @@ App::DocumentObjectExecReturn *Transformed::execute(void) // Check for intersection with support if (!Part::checkIntersection(support, mkTrf.Shape(), false)) { Base::Console().Warning("Transformed shape does not intersect support %s: Removed\n", (*o)->getNameInDocument()); - // Note: The removal happens in getSolid() after the fuse. If we remove here, - // the histories get messed up and we get a crash + // Note: The removal happens in getSolid() after the fuse rejected.push_back(*t); } builder.Add(transformedShapes, mkTrf.Shape()); @@ -175,12 +174,10 @@ App::DocumentObjectExecReturn *Transformed::execute(void) BRepBndLib::Add(trfShape, transformed_bb); if (support_bb.Distance(transformed_bb) > Precision::Confusion()) { Base::Console().Warning("Transformed shape does not intersect support %s: Removed\n", (*o)->getNameInDocument()); - // Note: The removal happens in getSolid() after the fuse. If we remove here, - // the histories get messed up and we get a crash + // Note: The removal happens in getSolid() after the fuse } builder.Add(transformedShapes, trfShape); v_transformedShapes.push_back(trfShape); - */ }